You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Kaloyan Kolev (JIRA)" <ji...@apache.org> on 2009/10/21 16:29:59 UTC
[jira] Created: (WINK-219) JAXBXmlProvider should be able to handle
inherited types, since JAXB is able to handle them
JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
-------------------------------------------------------------------------------------------
Key: WINK-219
URL: https://issues.apache.org/jira/browse/WINK-219
Project: Wink
Issue Type: Bug
Components: Common
Affects Versions: 0.2
Reporter: Kaloyan Kolev
Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Kaloyan Kolev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768277#action_12768277 ]
Kaloyan Kolev commented on WINK-219:
------------------------------------
Isn't the user the one that is responsible for providing the type of the entity to use when serializing? Meaning that If the generic type is an instance of class it should be passed through the same checks the raw type has been passed on the first place. This should make sense for the most of the cases. If the generic type is instance of another derivative we could use a more flexible approach as you suggest.
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.2
> Reporter: Kaloyan Kolev
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848923#action_12848923 ]
Bryant Luk commented on WINK-219:
---------------------------------
I also got the same results but I think the expectation is for a resource method like:
{code}
@GET
public Response get() {
return Response.ok(new GenericEntity<AddNumbers>(new AddInts()) {}).build();
}
{code}
to work perhaps?
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849736#action_12849736 ]
Mike Rheinheimer commented on WINK-219:
---------------------------------------
No validation necessary; that's what unittests are for! :) Thanks for your clarifications and help. Patch is committed in SVN 927462.
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Fix For: 1.0
>
> Attachments: WINK-219.patch, WINK-219_2.patch, WINK-219_3.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer reassigned WINK-219:
-------------------------------------
Assignee: Mike Rheinheimer
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-219) JAXBXmlProvider should be able to handle
inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-219:
----------------------------------
Attachment: WINK-219.patch
I must be doing something wrong. :) If I read this jira and WINK-218 correctly, we expect JAXB to be able to handle an inherited JAXB type that has no JAXB annotations. So I might have:
{code}
@XmlAccessorType(XmlAccessType.FIELD)
@XmlType(name = "", propOrder = {
"arg0",
"arg1"
})
@XmlRootElement(name = "addNumbers")
public static class AddNumbers { }
public static class AddInts extends AddNumbers { }
{code}
And expect to be able to do this:
{code}
AddInts addInts = new AddInts();
// JAXBContext can handle inherited types?
JAXBContext context = JAXBContext.newInstance(AddInts.class);
Marshaller marshaller = context.createMarshaller();
Writer writer = new StringWriter();
marshaller.marshal(addInts, writer);
{code}
This didn't work out so good for me. I got exception:
{code}
...
Caused by: com.sun.istack.SAXException2: unable to marshal type "org.apache.wink.server.internal.providers.entity.JAXBProviderInheritanceTest$AddInts" as an element because it is missing an @XmlRootElement annotation
at com.sun.xml.bind.v2.runtime.XMLSerializer.reportError(XMLSerializer.java:242)
at com.sun.xml.bind.v2.runtime.ClassBeanInfoImpl.serializeRoot(ClassBeanInfoImpl.java:303)
at com.sun.xml.bind.v2.runtime.XMLSerializer.childAsRoot(XMLSerializer.java:488)
at com.sun.xml.bind.v2.runtime.MarshallerImpl.write(MarshallerImpl.java:317)
... 22 more
{code}
So, I put the @XmlRootElement annotation on my AddInts class, and it succeeds. In fact, the only check the JAXBXmlProvider performs before allowing the creation of the marshaller/unmarshaller instances is for the @XmlRootElement annotation. Looks like JAXBXmlProvider is doing the necessary and appropriate check. So I think we're all done here. Maybe this got fixed between opening the jira and now?
Anyway, please review and confirm. See attached test patch.
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850100#action_12850100 ]
Hudson commented on WINK-219:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #299 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/299/])
: best-effort to support JAXB inherited types
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Fix For: 1.0
>
> Attachments: WINK-219.patch, WINK-219_2.patch, WINK-219_3.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Kaloyan Kolev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849177#action_12849177 ]
Kaloyan Kolev commented on WINK-219:
------------------------------------
To try to make it more clearer I would also expect this to translate to something like:
{code}
AddInts addInts = new AddInts();
JAXBContext context = JAXBContext.newInstance(AddInts.class, AddNumbers.class); \
// or just JAXBContext context = JAXBContext.newInstance(AddNumbers.class);
// not sure which of them is supposed to work.
Marshaller marshaller = context.createMarshaller();
Writer writer = new StringWriter();
// here you might also need to wrap it in JAXBElement to specify that the instance should
// be serialized as AddNumbers
marshaller.marshal(addInts, writer);
{code}
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch, WINK-219_2.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer resolved WINK-219.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.0
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Fix For: 1.0
>
> Attachments: WINK-219.patch, WINK-219_2.patch, WINK-219_3.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849041#action_12849041 ]
Mike Rheinheimer commented on WINK-219:
---------------------------------------
Thanks Bryant. So, I added a resource method that does as you describe, but with AddInts still annotated with @XmlRootElement. This worked. So refactored AddInts to be called AddIntsAnnotated and added another type called AddIntsNotAnnotated and ran the same test.
I temporarily changed JAXBXmlProvider.isWriteable to allow AddIntsNotAnnotated and changed the AbstractJAXBProvider.getDefaultContext to take both the type and genericType so they would *both* be included in the JAXBContext instance. I *still* get the same exception I reported above.
I'm thinking this is not supportable. The net of my testing so far shows that the Object passed down to the AbstractJAXBProvider.writeTo is AddIntsNotAnnotated, to which we cannot unmarshal due to JAXB requiring the @XmlRootElement annotation on that class. The class is already in the JAXBContext in my prototype, so it's certainly not a matter of it being missed during JAXBContext instance creation.
Maybe I need some clarification on the expectations. Please see the attached revised test. I have not included the prototype fix; the description above captures what I did.
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch, WINK-219_2.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Kaloyan Kolev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849173#action_12849173 ]
Kaloyan Kolev commented on WINK-219:
------------------------------------
As Bryant pointed my initial question was whether this code:
{code}
@GET
public Response get() {
return Response.ok(new GenericEntity(new AddIntsNotAnnotated(), AddNumbers.class) {}).build();
}
{code}
Should be serializable by the provider that understands how to handle the AddNumbers class. Please note the second argument being passed to the GenericEntity constructor as I would expect that it will be used when finding a provider.
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch, WINK-219_2.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-219) JAXBXmlProvider should be able to handle
inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-219:
----------------------------------
Attachment: WINK-219_2.patch
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch, WINK-219_2.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-219) JAXBXmlProvider should be able to handle
inherited types, since JAXB is able to handle them
Posted by "Nick Gallardo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Gallardo updated WINK-219:
-------------------------------
Priority: Minor (was: Major)
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Priority: Minor
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-219) JAXBXmlProvider should be able to handle
inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-219:
----------------------------------
Attachment: WINK-219_3.patch
Thanks Kaloyan. There's a solution in attached file WINK-219_3.patch that doesn't degrade performance and satisfies the feature request.
Please have a look. Thanks!
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch, WINK-219_2.patch, WINK-219_3.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Nick Gallardo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768267#action_12768267 ]
Nick Gallardo commented on WINK-219:
------------------------------------
{quote}
The best solution will be probably testing if the class can be handled. I'm not sure if there is a way to check it using JAXB APIs.
{quote}
We had to go through considerable gymnastics to get down to a usable set of classes in the JAX-WS support for Axis2. Here's a pointer to part of what we had to do to determine whether a class was usable:
http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/message/databinding/JAXBContextFromClasses.java?view=markup
Specifically, the separate() and findBestSet() methods are the key. The net is, if the class can be added to a JAXBContext, then the assumption is that the class is usable for marshalling/unmarshalling.
This is an alternative to an exhaustive approach of checking the class' hierarchy looking for JAXB annotations.
So... maybe that means we can assume that if the class is part of the JAXBContext that we have, then the isWritable should pass? Maybe, but something makes me uncomfortable with that approach.
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.2
> Reporter: Kaloyan Kolev
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Kaloyan Kolev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849711#action_12849711 ]
Kaloyan Kolev commented on WINK-219:
------------------------------------
Not sure if I should be validating your changes, but they look ok to me.
Thanks!
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
> Attachments: WINK-219.patch, WINK-219_2.patch, WINK-219_3.patch
>
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (WINK-219) JAXBXmlProvider should be able to
handle inherited types, since JAXB is able to handle them
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WINK-219 started by Mike Rheinheimer.
> JAXBXmlProvider should be able to handle inherited types, since JAXB is able to handle them
> -------------------------------------------------------------------------------------------
>
> Key: WINK-219
> URL: https://issues.apache.org/jira/browse/WINK-219
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0
> Reporter: Kaloyan Kolev
> Assignee: Mike Rheinheimer
> Priority: Minor
>
> Here is the issue which led to opening this one: https://issues.apache.org/jira/browse/WINK-218
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.