[jira] [Commented] (AIRFLOW-2916) Add argument `verify` for AwsHook() and S3 related sensors/operators

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584722#comment-16584722 ] 

ASF GitHub Bot commented on AIRFLOW-2916:
-----------------------------------------

XD-DENG opened a new pull request #3764: [AIRFLOW-2916] Arg `verify` for AwsHook() & S3 sensors/operators
URL: https://github.com/apache/incubator-airflow/pull/3764
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2916
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Background
   The `AwsHook()` and `S3`-related operators/sensors are depending on package `boto3`.
   
   In `boto3`, when we initiate a `client` or a `resource`, argument `verify` is provided (https://boto3.readthedocs.io/en/latest/reference/core/session.html ).
   
   ### Why do we need this
   It is useful when
   - users want to use a different CA cert bundle than the one used by `botocore`.
   - users want to have **'--no-verify-ssl'**. This is especially useful when we're using on-premises S3 or other implementations of object storage, like IBM's Cloud Object Storage.
   
   ### Backward Compatibility
   The default value here is always `None`, which is also the default value in `boto3`, so that backward compatibility is ensured too.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add argument `verify` for AwsHook() and S3 related sensors/operators
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-2916
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2916
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks, operators
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Minor
>
> The AwsHook() and S3-related operators/sensors are depending on package boto3.
> In boto3, when we initiate a client or a resource, argument `verify` is provided (https://boto3.readthedocs.io/en/latest/reference/core/session.html ).
> It is useful when
>  # users want to use a different CA cert bundle than the one used by botocore.
>  # users want to have '--no-verify-ssl'. This is especially useful when we're using on-premises S3 or other implementations of object storage, like IBM's Cloud Object Storage.
> However, this feature is not provided in Airflow for S3 yet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)