You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/15 13:08:58 UTC
[GitHub] [lucene] jpountz opened a new issue, #11933: Remove IOContext from `Directory#openChecksumInput`?
jpountz opened a new issue, #11933:
URL: https://github.com/apache/lucene/issues/11933
### Description
`ChecksumIndexInput` only allows reading files sequentially, so the only `IOContext` that makes sense is `IOContext.READONCE`?
### Version and environment details
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11933: Remove IOContext from `Directory#openChecksumInput`?
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316889438
I think we can remove it, but if we keep it maybe it should always use READONCE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11933: Remove IOContext from `Directory#openChecksumInput`?
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316719591
Hi,
I think the idea of IOContext was beyond simple flags like "sequentially reading" or "random IO" (and you can create your own IOContexts). I think we added that to allow full flexibility. For the checkum case it may be predefined, so yes, we could think of removing the argument.
I am +/-0 for removing it, on the other hand it does not hurt to have it for future extensibility. Do you have something in mind where it may hinder us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on issue #11933: Remove IOContext from `Directory#openChecksumInput`?
Posted by GitBox <gi...@apache.org>.
jpountz commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316595426
@uschindler @rmuir I wonder if you have thoughts on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on issue #11933: Remove IOContext from `Directory#openChecksumInput`?
Posted by GitBox <gi...@apache.org>.
jpountz commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316724527
I opened this issue because I found several instances of codecs opening their meta file with the default `IOContext` instead of using `READONCE`. https://github.com/apache/lucene/pull/11934 If we did not have the `IOContext` argument on `openChecksumInput`, these bugs would not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on issue #11933: Remove IOContext from `Directory#openChecksumInput`?
Posted by GitBox <gi...@apache.org>.
mikemccand commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1317075989
+1 to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] zacharymorn closed issue #11933: Remove IOContext from `Directory#openChecksumInput`?
Posted by GitBox <gi...@apache.org>.
zacharymorn closed issue #11933: Remove IOContext from `Directory#openChecksumInput`?
URL: https://github.com/apache/lucene/issues/11933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org