You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/01/03 07:04:08 UTC

Review Request 55126: Need to support permission in string format for FS action node

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55126/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.


Bugs: AMBARI-19335
    https://issues.apache.org/jira/browse/AMBARI-19335


Repository: ambari


Description
-------

We will finsout the permission format of the string and if it is string, we process and will convert it into number format and import it into WFD


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js af61c91 

Diff: https://reviews.apache.org/r/55126/diff/


Testing
-------

We have imported a workflow with permission in string format and have verified the preview XML and saved the workflow XML again and imported it to WFD to check the correctness.


Thanks,

venkat sairam


Re: Review Request 55126: Need to support permission in string format for FS action node

Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55126/#review160360
-----------------------------------------------------------


Ship it!




Ship It!

- Renjith Kamath


On Jan. 3, 2017, 9:38 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55126/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 9:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.
> 
> 
> Bugs: AMBARI-19335
>     https://issues.apache.org/jira/browse/AMBARI-19335
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We will finsout the permission format of the string and if it is string, we process and will convert it into number format and import it into WFD
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js af61c91 
> 
> Diff: https://reviews.apache.org/r/55126/diff/
> 
> 
> Testing
> -------
> 
> We have imported a workflow with permission in string format and have verified the preview XML and saved the workflow XML again and imported it to WFD to check the correctness.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 55126: Need to support permission in string format for FS action node

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55126/#review160358
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 3, 2017, 9:38 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55126/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 9:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.
> 
> 
> Bugs: AMBARI-19335
>     https://issues.apache.org/jira/browse/AMBARI-19335
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We will finsout the permission format of the string and if it is string, we process and will convert it into number format and import it into WFD
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js af61c91 
> 
> Diff: https://reviews.apache.org/r/55126/diff/
> 
> 
> Testing
> -------
> 
> We have imported a workflow with permission in string format and have verified the preview XML and saved the workflow XML again and imported it to WFD to check the correctness.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 55126: Need to support permission in string format for FS action node

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55126/
-----------------------------------------------------------

(Updated Jan. 3, 2017, 9:38 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.


Bugs: AMBARI-19335
    https://issues.apache.org/jira/browse/AMBARI-19335


Repository: ambari


Description
-------

We will finsout the permission format of the string and if it is string, we process and will convert it into number format and import it into WFD


Diffs (updated)
-----

  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js af61c91 

Diff: https://reviews.apache.org/r/55126/diff/


Testing
-------

We have imported a workflow with permission in string format and have verified the preview XML and saved the workflow XML again and imported it to WFD to check the correctness.


Thanks,

venkat sairam