You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/04/15 23:51:40 UTC

[GitHub] [druid] jgoz opened a new pull request #11119: Web console: update dev dependencies

jgoz opened a new pull request #11119:
URL: https://github.com/apache/druid/pull/11119


   <!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
   
   <!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
   
   
   <!-- If you are a committer, follow the PR action item checklist for committers:
   https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
   
   ### Description
   
   This PR updates web-console dependency versions that are relatively safe and straightforward to upgrade. Some highlights:
   
   - TypeScript 4.2
   - Webpack 5
   - Jest 26
   - Prettier 2 (via awesome-code-style)
   
   With the upgraded packages, `npm install` will now succeed on Node 14 without needing node-gyp.
   
   And a couple of configuration changes:
   - Enable sourcemaps in development mode for nicer debugging in the browser
   - Set TypeScript `module` format to `esnext` to allow webpack to tree-shake
   
   And finally, I removed some packages that were not being used.
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-820833251


   Thank you for the dependency updates, what a breath of fresh air!
   
   The CI failure in the e2e tests looks legit:
   
   ![image](https://user-images.githubusercontent.com/177816/114956424-af724180-9e13-11eb-9fa6-5e646f6df439.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] lgtm-com[bot] commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-821331388


   This pull request **fixes 1 alert** when merging 722b02dc7f2cdb06e3764faab035fc60a0bb5c44 into 26d1074ade7eb963d55f4afbde2dbd707bfc6c3a - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-2696b38d951319ebb7c9948f1d2411855d5f7ad8)
   
   **fixed alerts:**
   
   * 1 for Syntax error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-821756997


   ![image](https://user-images.githubusercontent.com/177816/115100247-50362f00-9ef0-11eb-88d7-9fe6cc55970f.png)
   
   ...
   
   ![image](https://user-images.githubusercontent.com/177816/115100254-5a582d80-9ef0-11eb-8a96-fee905007cb4.png)
   
   Nice first contrib. good start, keep it up!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] lgtm-com[bot] commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-821253367


   This pull request **fixes 1 alert** when merging 0b41cafdf845e9d33b3ae7ae097b902ff043269b into 26d1074ade7eb963d55f4afbde2dbd707bfc6c3a - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-35ed9aed69be6160a6c6113abca8445ac3d754e8)
   
   **fixed alerts:**
   
   * 1 for Syntax error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] lgtm-com[bot] commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-821649153


   This pull request **fixes 1 alert** when merging 0e91bcb3cca68e44025acd4def6848adc684e922 into 26d1074ade7eb963d55f4afbde2dbd707bfc6c3a - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-20bec3c01c1702690a2d227ae99cd1110fce3090)
   
   **fixed alerts:**
   
   * 1 for Syntax error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-820833929


   also with all the dependency updates please make sure to run the script `script/licenses` from the `web-console` directory. It should update the root license listing with the new versions of the modules per Apache requirements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] jgoz commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
jgoz commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-821253230


   @vogievetsky Thank you, I updated the licenses. It looks like `tslib >= 1.11.2` is now licensed under 0BSD, which does not require inclusion of the copyright header. (Druid formerly used 1.10, which was Apache 2.0 licensed).
   
   And I think the e2e test failure is due to Travis using a really old version of Node for that one step since it doesn't run through mvn. I'm not a Travis expert, but I attempted to ask it for Node 10 to match the rest of the pipeline. We'll see if he listens.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky merged pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #11119:
URL: https://github.com/apache/druid/pull/11119


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] lgtm-com[bot] commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-820812866


   This pull request **fixes 1 alert** when merging eca2e8d45a0966575ec2c51c916be7274ee45457 into cb7c6ac3145edbdfe10017ca1cde4056283a26b6 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-a9ad4a037b8759dc0fafaa19539866408c43aa2f)
   
   **fixed alerts:**
   
   * 1 for Syntax error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-821285667


   ![image](https://user-images.githubusercontent.com/177816/115053480-07e92380-9e94-11eb-9c15-9e9dbb619f16.png)
   
   Nice!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] lgtm-com[bot] commented on pull request #11119: Web console: update dev dependencies

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11119:
URL: https://github.com/apache/druid/pull/11119#issuecomment-821307655


   This pull request **fixes 1 alert** when merging 443f2c5f1c60baf3736bbbd5b56ba7f844192c41 into 26d1074ade7eb963d55f4afbde2dbd707bfc6c3a - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-4af98b62e7661b0a4b657b7bd28ffc97d01fd4d8)
   
   **fixed alerts:**
   
   * 1 for Syntax error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org