You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/24 22:46:29 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5600: Imx6 thumb

masayuki2009 commented on a change in pull request #5600:
URL: https://github.com/apache/incubator-nuttx/pull/5600#discussion_r814332158



##########
File path: libs/libc/machine/arm/armv7-a/arch_elf.c
##########
@@ -163,7 +172,12 @@ int up_relocate(FAR const Elf32_Rel *rel, FAR const Elf32_Sym *sym,
           }
 
         offset += sym->st_value - addr;
+
+#ifdef CONFIG_ARM_THUMB
+        if (offset & 2 || offset < (int32_t) 0xfe000000 ||

Review comment:
       @pkarashchenko 
   
   Done.
   I also applied the same coding style to existing code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org