You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ctubbsii (via GitHub)" <gi...@apache.org> on 2025/03/27 21:27:37 UTC
[I] Avoid reusing an old ClientTabletCache after it is invalidated [accumulo]
ctubbsii opened a new issue, #5434:
URL: https://github.com/apache/accumulo/issues/5434
The BatchWriter, BatchScanner, and ConditoinalWriter get a reference to a tablet locator and then keep it. So then something like the following could happen
1. Create a BatchWriter which gets a ref to a cache C1 for table TAB1.
2. clearTabletLocationCache() is called
3. Create a BatchWriter which gets a ref to a cache C2 for table TAB1
So now there two batch writers that reference two different cache instances for the same table. Things probably should not hold on to references to the cache. The code seems to do that because it wraps the cache w/ decorator objects.
_Originally posted by @keith-turner in https://github.com/apache/accumulo/pull/5421#discussion_r2015052826_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Avoid reusing an old ClientTabletCache after it is invalidated [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on issue #5434:
URL: https://github.com/apache/accumulo/issues/5434#issuecomment-2770552797
It appears that `SyncingClientTabletCache` (a subclass of `ClientTabletCache`) was introduced to address this issue by checking `ClientTabletCache.isValid()` before each operation. While I'm still getting familiar with the code, I'm wondering if we could move this validity check directly into the base `ClientTabletCache` so that all implementations automatically benefit from it. Do we know if there is a specific reason why any `ClientTabletCache` implementation should avoid this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org