You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/15 17:21:54 UTC

[GitHub] [gobblin] Will-Lo commented on a change in pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies

Will-Lo commented on a change in pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#discussion_r651998293



##########
File path: .github/workflows/build_and_test.yaml
##########
@@ -49,6 +49,9 @@ jobs:
           # Only rebuild cache if build.gradle is changed
           key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
           restore-keys: ${{ runner.os }}-gradle
+      - name: Verify Dependencies
+        run: |
+          eval ./gradlew assemble

Review comment:
       @aplex This might be a design issue with how I did the pipeline, but I also added some caching on the build step to shorten build times. I think it ends up caching dependencies so transitive dependency issues don't get detected by the pipeline.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org