You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/18 17:06:46 UTC
[GitHub] [iceberg] Fokko opened a new pull request #2110: Move to Hive 2.3.8
Fokko opened a new pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110
Contains Avro 1.10 :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] sunchao commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-770440648
@Fokko it was removed as part of shading Guava- see [HIVE-22126](https://issues.apache.org/jira/browse/HIVE-22126) and [HIVE-23980](https://issues.apache.org/jira/browse/HIVE-23980).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-770097333
Why does this need to add Calcite dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dongjoon-hyun commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-762435382
It seems that CI fails.
cc @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-771071959
Looks good. Thanks for catching the test issue, @rdsr!
Thanks for the update, @Fokko!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-770437552
@sunchao Can you shed some light on why calcite has been removed as a dependency from Hive? I haven't been involved in this discussion.
@rdsr Good catch, I've moved them to `testCompile`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-766435309
Thanks for pointing out @sunchao. I've added calcite-core as a dependency as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdsr commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
rdsr commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-770327766
> Great to see this! I think you will need to specify version for calcite-core as well since it is excluded from hive-exec.
>
> Note Hive 2.3.8 still uses Avro 1.8.2, although it should be compatible with Avro 1.10.
Seems like calcite-druid is only required during `iceberg-mr` testing [calcite-core is already include in test scope]. Instead of adding at compileOnly, I think we should only add calcite druid as a test dep under `iceberg-mr` only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-766435309
Thanks for pointing out @sunchao. I've added calcite-core as a dependency as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dongjoon-hyun commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-766435761
Thank you for updating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] sunchao commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-762445221
Great to see this! I think you will need to specify version for calcite-core as well since it is excluded from hive-exec.
Note Hive 2.3.8 still uses Avro 1.8.2, although it should be compatible with Avro 1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dongjoon-hyun commented on pull request #2110: Move to Hive 2.3.8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #2110:
URL: https://github.com/apache/iceberg/pull/2110#issuecomment-766435761
Thank you for updating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org