You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "hewenting (Code Review)" <ge...@cloudera.org> on 2016/09/28 08:23:19 UTC

[Impala-ASF-CR] IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

hewenting has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4553

Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"
......................................................................

IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

squash MPALA-4057 and IMPALA-4050 patches.

Change-Id: I54280a25c3709e2f316a17a6baf33dbbbae720c0
---
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
M tests/common/impala_cluster.py
M tests/common/impala_service.py
4 files changed, 28 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/4553/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4553
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54280a25c3709e2f316a17a6baf33dbbbae720c0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>

[Impala-ASF-CR] IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"
......................................................................

Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4553/1/be/src/util/webserver-test.cc
File be/src/util/webserver-test.cc:

Line 94:
Please also add a test setting FLAGS_webserver_interface to "127.0.0.1" to make sure that specifying an IP address works.

PS1, Line 95: DefaultInterfaceTest
I couldn't get this test to compile, your method should be declared with "TEST(...)" (see below).

PS1, Line 103: Test
I think this needs to be all uppercase for gtest to work. It's also better to follow the convention.

PS1, Line 104: ScopedFlagSetter
You will need to move this test below ScopedFlagSetter to get this to compile.

Line 105: "localhost");
single line

http://gerrit.cloudera.org:8080/#/c/4553/1/be/src/util/webserver.cc
File be/src/util/webserver.cc:

Line 234: LOG(INFO) << "Starting webserver on " << http_address_;
Can you move this down and output the listening_spec instead? Knowing the IP address looks more helpful to me.

--
To view, visit http://gerrit.cloudera.org:8080/4553
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54280a25c3709e2f316a17a6baf33dbbbae720c0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes