You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by mr...@apache.org on 2008/09/09 17:36:32 UTC
svn commit: r693486 -
/xerces/java/trunk/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java
Author: mrglavas
Date: Tue Sep 9 08:36:31 2008
New Revision: 693486
URL: http://svn.apache.org/viewvc?rev=693486&view=rev
Log:
Fixing a potential NPE. The Javadoc for XMLGrammarPool.retrieveInitialGrammarSet() doesn't
explicitly disallow null as a return value. It's possible that some user implementations will
return null.
Modified:
xerces/java/trunk/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java
Modified: xerces/java/trunk/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java?rev=693486&r1=693485&r2=693486&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java Tue Sep 9 08:36:31 2008
@@ -667,9 +667,10 @@
// call handlers
// get initial grammars
- if(fGrammarPool != null) {
+ if (fGrammarPool != null) {
Grammar [] grammars = fGrammarPool.retrieveInitialGrammarSet(XMLGrammarDescription.XML_DTD);
- for(int i = 0; i<grammars.length; i++) {
+ final int length = (grammars != null) ? grammars.length : 0;
+ for (int i = 0; i < length; ++i) {
fGrammarBucket.putGrammar((DTDGrammar)grammars[i]);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org