You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:56:25 UTC

Review Request 65861: Windows: Removed use of W* signal macros in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65861/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Repository: mesos


Description
-------

Windows doesn't use signals, so all uses of the W* signal macros on
Windows has been #ifdef'd out.


Diffs
-----

  3rdparty/libprocess/include/process/gtest.hpp dd4c9bdf7e6e0e45db347108fde3b41960974be6 


Diff: https://reviews.apache.org/r/65861/diff/1/


Testing
-------


Thanks,

Akash Gupta


Re: Review Request 65861: Windows: Removed use of W* signal macros in libprocess.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65861/#review198567
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On March 1, 2018, 1:56 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65861/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 1:56 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows doesn't use signals, so all uses of the W* signal macros on
> Windows has been #ifdef'd out.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp dd4c9bdf7e6e0e45db347108fde3b41960974be6 
> 
> 
> Diff: https://reviews.apache.org/r/65861/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>