[GitHub] [incubator-pinot] npawar commented on issue #4170: Make realtime server upload timeout configurable

[GitBox <gi...@apache.org>]

npawar commented on issue #4170: Make realtime server upload timeout configurable
URL: https://github.com/apache/incubator-pinot/pull/4170#issuecomment-487226640
 
 
   @Jackie-Jiang fixed the `:` and `space` and moved config keys to CommonConstants. I prefer not to add single quotes around segment. I believe the segment name cannot have trailing or leading spaces in that particular place. 
   @jenniferdai the offline segment upload timeouts will be configured at the client applications which are responsible for pushing segments. I didn't see any such config or defaults on our end. Also, I prefer if we keep the realtime upload times separate, as we are more in control of the segment end-to-end, as compared to offline. Does that work?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org