You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/21 18:52:31 UTC

[GitHub] mseth10 commented on a change in pull request #14107: fix nd.slice for following outputs: (1) begin=end and (2) end=-1, step=-1

mseth10 commented on a change in pull request #14107: fix nd.slice for following outputs: (1) begin=end and (2) end=-1, step=-1
URL: https://github.com/apache/incubator-mxnet/pull/14107#discussion_r259066681
 
 

 ##########
 File path: src/operator/tensor/matrix_op-inl.h
 ##########
 @@ -653,6 +653,7 @@ inline void GetIndexRange(const TShape& dshape,
   }
 
   for (index_t i = 0; i < param_begin.ndim(); ++i) {
+    CHECK_NE(dshape[i], 0) << "Invalid input shape!";
 
 Review comment:
   Agreed. Will consider it a valid input.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services