You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "cgivre (via GitHub)" <gi...@apache.org> on 2023/03/09 04:20:45 UTC

[PR] DRILL-8408: Allow Implicit Casts on Join (drill)

cgivre opened a new pull request, #2772:
URL: https://github.com/apache/drill/pull/2772

   # [DRILL-8048](https://issues.apache.org/jira/browse/DRILL-8408): Allow Implicit Casts on Join
   
   ## Description
   With the revision of Drill's implicit casting rules as a part of DRILL-8136, Drill now supports much improved implicit casting logic.  However, that does not carry over to joins.  This PR allows the implicit casting to carry through to joins as well. 
   
   ## Documentation
   N/A
   
   ## Testing
   Ran existing unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DRILL-8408: Allow Implicit Casts on Join (drill)

Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2772:
URL: https://github.com/apache/drill/pull/2772#issuecomment-1464068067

   I agree that it would be nice to be able to switch this on or off using a session option. And I wonder if we should begin with that option defaulted to false so that we can 
   
   1. include this in 1.21.x and 
   2. collect some experience from opt-ins (like ourselves) about whether such joins turn out to be badly behaved, before exposing out-of-the-box users to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DRILL-8408: Allow Implicit Casts on Join (drill)

Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2772:
URL: https://github.com/apache/drill/pull/2772#issuecomment-1464476318

   > I agree that it would be nice to be able to switch this on or off using a session option. And I wonder if we should begin with that option defaulted to false so that we can
   > 
   > 1. include this in 1.21.x and
   > 2. collect some experience from opt-ins (like ourselves) about whether such joins turn out to be badly behaved, before exposing out-of-the-box users to it.
   
   I added a new exec option defaulted to `false`.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DRILL-8408: Allow Implicit Casts on Join (drill)

Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre merged PR #2772:
URL: https://github.com/apache/drill/pull/2772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DRILL-8408: Allow Implicit Casts on Join (drill)

Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2772:
URL: https://github.com/apache/drill/pull/2772#issuecomment-1462040949

   @jnturton @vvysotskyi I don't know if these checks were there for a reason or not, but with the improved implicit casting from DRILL-8316, this PR seems to work.   
   
   If there's a performance reason we shouldn't do this, I was thinking that we could add an exec option to enable/disable this functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org