You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Yuanhao Luo (Code Review)" <ge...@cloudera.org> on 2016/09/05 07:56:16 UTC
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Yuanhao Luo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4311
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
IMPALA-4074: Configuration items duplicate in template of YARN
Remove duplicate configuration items "yarn.nodemanager.local-dirs"
and "yarn.nodemanager.log-dirs" from template configuration of YARN.
Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.tmpl
1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/4311/1
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
IMPALA-4074: Configuration items duplicate in template of YARN
Remove duplicate configuration items "yarn.nodemanager.local-dirs"
and "yarn.nodemanager.log-dirs" from template configuration of YARN.
Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Reviewed-on: http://gerrit.cloudera.org:8080/4311
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.tmpl
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Internal Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
Patch Set 1: Code-Review+2
Thanks, just wanted to understand!
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
Patch Set 2: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
Patch Set 1:
The change looks fine in principle - good catch. Have you tested it at all?
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Posted by "Yuanhao Luo (Code Review)" <ge...@cloudera.org>.
Yuanhao Luo has posted comments on this change.
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
Patch Set 1:
Yes, I have run the test. The result shows that the later one takes effect. Besides, I think that the later one location is much more proper than the former one, so I just remov the former one in this patch.
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4074: Configuration items duplicate in template of YARN
......................................................................
Patch Set 1:
I'm going to run tests and merge this.
--
To view, visit http://gerrit.cloudera.org:8080/4311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d6d019d4982cb35932b1d45c376b215ec5bcc6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No