You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/06/08 09:56:21 UTC
[PR] Add SHOW RECEIVERS support [iotdb]
Caideyipi opened a new pull request, #17869:
URL: https://github.com/apache/iotdb/pull/17869
## Summary
- add tree-model SHOW RECEIVERS and table-model information_schema.receivers support
- track active pipe receiver sessions, sender endpoints, pipe IDs, handshake/transfer timestamps, and request counts
- wire DataNode/ConfigNode thrift and air-gap receiver runtime recording
## Tests
- mvn "-Ddevelocity.off=true" -pl iotdb-core/node-commons -Dtest=PipeReceiverRuntimeRegistryTest test
- mvn "-Ddevelocity.off=true" -DskipTests compile -pl iotdb-core/antlr,iotdb-core/relational-grammar,iotdb-core/node-commons,iotdb-core/confignode
- mvn "-Ddevelocity.off=true" -DskipTests spotless:check -pl iotdb-core/node-commons,iotdb-core/datanode,iotdb-core/confignode,iotdb-core/relational-grammar,iotdb-core/antlr
- git diff --check
## Notes
- DataNode focused compile is still blocked by unrelated generated Freemarker/calc symbols such as IFill, LinearFill, Accumulator, ComparatorChain, and IoTDBConfig.getModeMapSizeThreshold().
- ConfigNode receiver records proxied through DataNode use receiver_node_id = -1 because the current proxy path does not expose the exact target ConfigNode id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4707273249
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-5437045243
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=ae930b7c46a33a27293bde477729a345c5ee19e2783c3090b08a8c3a3248ce2c -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4718049548
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 commented on code in PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#discussion_r3860606599
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
+
+ private void recordConfigNodeHandshake(
+ final TPipeTransferReq req, final PipeRequestType requestType, final int receiverNodeId) {
+ final String protocol = getProtocol(req);
+ final String sessionKey =
+ String.format(
+ "%s-%s-%s-%s",
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getConfigReceiverId());
+ final String oldSessionKey = configPipeReceiverRuntimeSessionKey.getAndSet(sessionKey);
+ if (!Objects.equals(oldSessionKey, sessionKey)) {
+ PipeReceiverRuntimeRegistry.getInstance().deregister(oldSessionKey);
+ }
+
+ final Map<String, String> params =
+ requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2
+ ? parseHandshakeV2Params(req)
+ : Collections.emptyMap();
+ PipeReceiverRuntimeRegistry.getInstance()
+ .registerOrUpdateSession(
+ sessionKey,
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getSenderHost(),
+ parseSenderPort(getSenderPort()),
Review Comment:
Why are both needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4690527018
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=c721c67aca31e84f0274ae25025b61ca214d6871b1457fe409e918a6de6a24fa -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4921454597
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate passed**
Issues
 [52 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_coverage&view=list)
 [3.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4764305263
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=0f2eeca128cdb591a3c21ced893a5d80941fd7157db4b6022c66edc3b81f6ffd -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-5324834828
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=281f5949f243e293350692997abc82d298d4401c0fc60220c142c52250d6425a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4737097395
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4717541236
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#discussion_r3987543070
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
Review Comment:
Applied. The ConfigNode runtime helper is now a void side-effect method, and the original response is returned explicitly at the call site.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
+
+ private void recordConfigNodeHandshake(
+ final TPipeTransferReq req, final PipeRequestType requestType, final int receiverNodeId) {
+ final String protocol = getProtocol(req);
+ final String sessionKey =
+ String.format(
+ "%s-%s-%s-%s",
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getConfigReceiverId());
+ final String oldSessionKey = configPipeReceiverRuntimeSessionKey.getAndSet(sessionKey);
+ if (!Objects.equals(oldSessionKey, sessionKey)) {
+ PipeReceiverRuntimeRegistry.getInstance().deregister(oldSessionKey);
+ }
+
+ final Map<String, String> params =
+ requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2
+ ? parseHandshakeV2Params(req)
+ : Collections.emptyMap();
+ PipeReceiverRuntimeRegistry.getInstance()
+ .registerOrUpdateSession(
+ sessionKey,
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getSenderHost(),
+ parseSenderPort(getSenderPort()),
+ params.getOrDefault(PipeTransferHandshakeConstant.HANDSHAKE_KEY_USERNAME, username),
+ params.getOrDefault(
+ PipeTransferHandshakeConstant.HANDSHAKE_KEY_CLUSTER_ID,
+ PipeReceiverRuntimeRegistry.UNKNOWN),
+ params.get(PipeTransferHandshakeConstant.HANDSHAKE_KEY_PIPE_NAME),
+ parsePipeCreationTime(
+ params.get(PipeTransferHandshakeConstant.HANDSHAKE_KEY_PIPE_CREATION_TIME)),
+ System.currentTimeMillis());
+ }
+
+ private static Map<String, String> parseHandshakeV2Params(final TPipeTransferReq req) {
+ final Map<String, String> params = new HashMap<>();
+ if (req.getBody() == null) {
+ return params;
+ }
Review Comment:
Applied. The null-body check now happens before allocating the map and returns Collections.emptyMap().
##########
integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/auto/basic/IoTDBShowReceiversLifecycleIT.java:
##########
@@ -0,0 +1,379 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.pipe.it.dual.treemodel.auto.basic;
+
+import org.apache.iotdb.common.rpc.thrift.TSStatus;
+import org.apache.iotdb.commons.client.sync.SyncConfigNodeIServiceClient;
+import org.apache.iotdb.confignode.rpc.thrift.TCreatePipeReq;
+import org.apache.iotdb.db.it.utils.TestUtils;
+import org.apache.iotdb.isession.SessionConfig;
+import org.apache.iotdb.it.env.cluster.node.DataNodeWrapper;
+import org.apache.iotdb.it.framework.IoTDBTestRunner;
+import org.apache.iotdb.itbase.category.MultiClusterIT2DualTreeAutoBasic;
+import org.apache.iotdb.itbase.env.BaseEnv;
+import org.apache.iotdb.pipe.it.dual.treemodel.auto.AbstractPipeDualTreeModelAutoIT;
+import org.apache.iotdb.rpc.TSStatusCode;
+
+import org.awaitility.Awaitility;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+@RunWith(IoTDBTestRunner.class)
+@Category({MultiClusterIT2DualTreeAutoBasic.class})
+public class IoTDBShowReceiversLifecycleIT extends AbstractPipeDualTreeModelAutoIT {
+
+ @Override
+ protected void setupConfig() {
+ super.setupConfig();
+ senderEnv.getConfig().getCommonConfig().setPipeAirGapReceiverEnabled(true);
+ receiverEnv.getConfig().getCommonConfig().setPipeAirGapReceiverEnabled(true);
+ }
+
+ @Test
+ public void testShowReceiversPipeIdsDisappearAfterDropPipe() throws Exception {
+ final String database = "root.show_receivers_lifecycle";
+ final String pipeName = "show_receivers_lifecycle_pipe";
+
+ createThriftPipe(database, pipeName);
+
+ assertShowReceivers("show receivers", BaseEnv.TREE_SQL_DIALECT, pipeName);
+ assertShowReceivers(
+ "select * from information_schema.receivers", BaseEnv.TABLE_SQL_DIALECT, pipeName);
Review Comment:
Applied. This lifecycle IT is tree-model-only now; table-model information_schema.receivers coverage remains in IoTDBShowReceiversIT.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
+
+ private void recordConfigNodeHandshake(
+ final TPipeTransferReq req, final PipeRequestType requestType, final int receiverNodeId) {
+ final String protocol = getProtocol(req);
+ final String sessionKey =
+ String.format(
+ "%s-%s-%s-%s",
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getConfigReceiverId());
+ final String oldSessionKey = configPipeReceiverRuntimeSessionKey.getAndSet(sessionKey);
+ if (!Objects.equals(oldSessionKey, sessionKey)) {
+ PipeReceiverRuntimeRegistry.getInstance().deregister(oldSessionKey);
+ }
+
+ final Map<String, String> params =
+ requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2
+ ? parseHandshakeV2Params(req)
+ : Collections.emptyMap();
+ PipeReceiverRuntimeRegistry.getInstance()
+ .registerOrUpdateSession(
+ sessionKey,
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getSenderHost(),
+ parseSenderPort(getSenderPort()),
Review Comment:
Both values are required: the sender host identifies the source for runtime aggregation, while the sender port records the actual connection endpoint and populates sender_ports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4686882056
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=6b44401ee24403abae8d7dca51964325cfb1cee473cbc32c9afd10078b6e1383 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4714769258
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4725824505
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4714338317
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4714561006
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4764697742
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=0f2eeca128cdb591a3c21ced893a5d80941fd7157db4b6022c66edc3b81f6ffd -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4679877906
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=56575c4f113ec38768c8770cfa39c2d07adaf585c4aa1949490da0193d8a9def -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4913745346
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate passed**
Issues
 [50 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_coverage&view=list)
 [3.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 commented on code in PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#discussion_r3860546066
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
Review Comment:
The return value is fixed. Is it necessary?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
+
+ private void recordConfigNodeHandshake(
+ final TPipeTransferReq req, final PipeRequestType requestType, final int receiverNodeId) {
+ final String protocol = getProtocol(req);
+ final String sessionKey =
+ String.format(
+ "%s-%s-%s-%s",
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getConfigReceiverId());
+ final String oldSessionKey = configPipeReceiverRuntimeSessionKey.getAndSet(sessionKey);
+ if (!Objects.equals(oldSessionKey, sessionKey)) {
+ PipeReceiverRuntimeRegistry.getInstance().deregister(oldSessionKey);
+ }
+
+ final Map<String, String> params =
+ requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2
+ ? parseHandshakeV2Params(req)
+ : Collections.emptyMap();
+ PipeReceiverRuntimeRegistry.getInstance()
+ .registerOrUpdateSession(
+ sessionKey,
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getSenderHost(),
+ parseSenderPort(getSenderPort()),
Review Comment:
Why are both needed.
##########
integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/auto/basic/IoTDBShowReceiversLifecycleIT.java:
##########
@@ -0,0 +1,379 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.pipe.it.dual.treemodel.auto.basic;
+
+import org.apache.iotdb.common.rpc.thrift.TSStatus;
+import org.apache.iotdb.commons.client.sync.SyncConfigNodeIServiceClient;
+import org.apache.iotdb.confignode.rpc.thrift.TCreatePipeReq;
+import org.apache.iotdb.db.it.utils.TestUtils;
+import org.apache.iotdb.isession.SessionConfig;
+import org.apache.iotdb.it.env.cluster.node.DataNodeWrapper;
+import org.apache.iotdb.it.framework.IoTDBTestRunner;
+import org.apache.iotdb.itbase.category.MultiClusterIT2DualTreeAutoBasic;
+import org.apache.iotdb.itbase.env.BaseEnv;
+import org.apache.iotdb.pipe.it.dual.treemodel.auto.AbstractPipeDualTreeModelAutoIT;
+import org.apache.iotdb.rpc.TSStatusCode;
+
+import org.awaitility.Awaitility;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+@RunWith(IoTDBTestRunner.class)
+@Category({MultiClusterIT2DualTreeAutoBasic.class})
+public class IoTDBShowReceiversLifecycleIT extends AbstractPipeDualTreeModelAutoIT {
+
+ @Override
+ protected void setupConfig() {
+ super.setupConfig();
+ senderEnv.getConfig().getCommonConfig().setPipeAirGapReceiverEnabled(true);
+ receiverEnv.getConfig().getCommonConfig().setPipeAirGapReceiverEnabled(true);
+ }
+
+ @Test
+ public void testShowReceiversPipeIdsDisappearAfterDropPipe() throws Exception {
+ final String database = "root.show_receivers_lifecycle";
+ final String pipeName = "show_receivers_lifecycle_pipe";
+
+ createThriftPipe(database, pipeName);
+
+ assertShowReceivers("show receivers", BaseEnv.TREE_SQL_DIALECT, pipeName);
+ assertShowReceivers(
+ "select * from information_schema.receivers", BaseEnv.TABLE_SQL_DIALECT, pipeName);
Review Comment:
Why can a tree pipe be shown in the table model?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
+
+ private void recordConfigNodeHandshake(
+ final TPipeTransferReq req, final PipeRequestType requestType, final int receiverNodeId) {
+ final String protocol = getProtocol(req);
+ final String sessionKey =
+ String.format(
+ "%s-%s-%s-%s",
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getConfigReceiverId());
+ final String oldSessionKey = configPipeReceiverRuntimeSessionKey.getAndSet(sessionKey);
+ if (!Objects.equals(oldSessionKey, sessionKey)) {
+ PipeReceiverRuntimeRegistry.getInstance().deregister(oldSessionKey);
+ }
+
+ final Map<String, String> params =
+ requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2
+ ? parseHandshakeV2Params(req)
+ : Collections.emptyMap();
+ PipeReceiverRuntimeRegistry.getInstance()
+ .registerOrUpdateSession(
+ sessionKey,
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getSenderHost(),
+ parseSenderPort(getSenderPort()),
+ params.getOrDefault(PipeTransferHandshakeConstant.HANDSHAKE_KEY_USERNAME, username),
+ params.getOrDefault(
+ PipeTransferHandshakeConstant.HANDSHAKE_KEY_CLUSTER_ID,
+ PipeReceiverRuntimeRegistry.UNKNOWN),
+ params.get(PipeTransferHandshakeConstant.HANDSHAKE_KEY_PIPE_NAME),
+ parsePipeCreationTime(
+ params.get(PipeTransferHandshakeConstant.HANDSHAKE_KEY_PIPE_CREATION_TIME)),
+ System.currentTimeMillis());
+ }
+
+ private static Map<String, String> parseHandshakeV2Params(final TPipeTransferReq req) {
+ final Map<String, String> params = new HashMap<>();
+ if (req.getBody() == null) {
+ return params;
+ }
Review Comment:
Move the judgment to the very beginning and return Collections.emptyMap if the map will not be written later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4737612664
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=93563f3ec05886eb87343783cc3ad8d306e1df9038d97e91f633b181cc33ba96 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4875177630
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate passed**
Issues
 [51 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_coverage&view=list)
 [3.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4829068423
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=0f2eeca128cdb591a3c21ced893a5d80941fd7157db4b6022c66edc3b81f6ffd -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4689648627
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=c721c67aca31e84f0274ae25025b61ca214d6871b1457fe409e918a6de6a24fa -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4703986287
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=c721c67aca31e84f0274ae25025b61ca214d6871b1457fe409e918a6de6a24fa -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4705106320
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=c721c67aca31e84f0274ae25025b61ca214d6871b1457fe409e918a6de6a24fa -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4686727113
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=56575c4f113ec38768c8770cfa39c2d07adaf585c4aa1949490da0193d8a9def -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#discussion_r3987543117
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -1126,6 +1162,122 @@ protected TSStatus getReceiverTemporaryUnavailableStatus(
PipeDataNodeResourceManager.memory().getTotalNonFloatingMemorySizeInBytes()));
}
+ private TPipeTransferResp recordDataNodeHandshakeIfSuccess(
+ final TPipeTransferResp resp, final TPipeTransferReq req) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverHandshake(
+ PipeReceiverRuntimeRegistry.NODE_TYPE_DATA_NODE,
+ IOTDB_CONFIG.getDataNodeId(),
+ getProtocol(req));
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordDataNodeTransferIfSuccess(final TPipeTransferResp resp) {
+ if (isSuccess(resp)) {
+ recordPipeReceiverTransfer();
+ }
+ return resp;
+ }
+
+ private TPipeTransferResp recordConfigNodeReceiverRuntimeIfSuccess(
+ final Pair<TPipeTransferResp, Integer> respWithReceiverNodeId, final TPipeTransferReq req) {
+ final TPipeTransferResp resp = respWithReceiverNodeId.left;
+ if (!PipeRequestType.isValidatedRequestType(req.getType())) {
+ return resp;
+ }
+
+ final PipeRequestType requestType = PipeRequestType.valueOf(req.getType());
+ if (requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V1
+ || requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2) {
+ if (isSuccess(resp)) {
+ recordConfigNodeHandshake(req, requestType, respWithReceiverNodeId.right);
+ }
+ } else {
+ if (isSuccess(resp)) {
+ PipeReceiverRuntimeRegistry.getInstance()
+ .markTransfer(configPipeReceiverRuntimeSessionKey.get(), System.currentTimeMillis());
+ }
+ }
+ return resp;
+ }
+
+ private void recordConfigNodeHandshake(
+ final TPipeTransferReq req, final PipeRequestType requestType, final int receiverNodeId) {
+ final String protocol = getProtocol(req);
+ final String sessionKey =
+ String.format(
+ "%s-%s-%s-%s",
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getConfigReceiverId());
+ final String oldSessionKey = configPipeReceiverRuntimeSessionKey.getAndSet(sessionKey);
+ if (!Objects.equals(oldSessionKey, sessionKey)) {
+ PipeReceiverRuntimeRegistry.getInstance().deregister(oldSessionKey);
+ }
+
+ final Map<String, String> params =
+ requestType == PipeRequestType.HANDSHAKE_CONFIGNODE_V2
+ ? parseHandshakeV2Params(req)
+ : Collections.emptyMap();
+ PipeReceiverRuntimeRegistry.getInstance()
+ .registerOrUpdateSession(
+ sessionKey,
+ PipeReceiverRuntimeRegistry.NODE_TYPE_CONFIG_NODE,
+ receiverNodeId,
+ protocol,
+ getSenderHost(),
+ parseSenderPort(getSenderPort()),
Review Comment:
Both values are required: the sender host identifies the source for runtime aggregation, while the sender port records the actual connection endpoint and populates sender_ports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4976694558
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate passed**
Issues
 [51 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17869&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17869&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_coverage&view=list)
 [3.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17869&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-5126011243
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=e65e2799a7534ac650f978de9fa923b0e8f299e1a0298e3441e6d90ede484d7d -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4680168306
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/17869?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `60.55901%` with `254 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.12%. Comparing base ([`283bce2`](https://app.codecov.io/gh/apache/iotdb/commit/283bce2f34c9ec171a774d9e5b0fb00a85c94bf0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5d21e1e`](https://app.codecov.io/gh/apache/iotdb/commit/5d21e1eb960d943bb12cf27ec717e2a491c27279?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/17869?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...eceiver/protocol/thrift/IoTDBDataNodeReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Fprotocol%2Fthrift%2FIoTDBDataNodeReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci9wcm90b2NvbC90aHJpZnQvSW9UREJEYXRhTm9kZVJlY2VpdmVyLmphdmE=) | 14.15% | [97 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...b/queryengine/plan/planner/LogicalPlanBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FLogicalPlanBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL0xvZ2ljYWxQbGFuQnVpbGRlci5qYXZh) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...iotdb/commons/pipe/receiver/IoTDBFileReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Freceiver%2FIoTDBFileReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9yZWNlaXZlci9Jb1REQkZpbGVSZWNlaXZlci5qYXZh) | 59.18% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ipe/receiver/protocol/IoTDBConfigNodeReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fpipe%2Freceiver%2Fprotocol%2FIoTDBConfigNodeReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9yZWNlaXZlci9wcm90b2NvbC9Jb1REQkNvbmZpZ05vZGVSZWNlaXZlci5qYXZh) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...db/db/queryengine/plan/analyze/AnalyzeVisitor.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fanalyze%2FAnalyzeVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9hbmFseXplL0FuYWx5emVWaXNpdG9yLmphdmE=) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ueryengine/plan/planner/OperatorTreeGenerator.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FOperatorTreeGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL09wZXJhdG9yVHJlZUdlbmVyYXRvci5qYXZh) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ecution/operator/source/ShowReceiversOperator.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fexecution%2Foperator%2Fsource%2FShowReceiversOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL29wZXJhdG9yL3NvdXJjZS9TaG93UmVjZWl2ZXJzT3BlcmF0b3IuamF2YQ==) | 81.96% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...an/planner/plan/node/source/ShowReceiversNode.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2Fsource%2FShowReceiversNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS9zb3VyY2UvU2hvd1JlY2VpdmVyc05vZGUuamF2YQ==) | 54.54% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ion/config/executor/ClusterConfigTaskExecutor.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fexecution%2Fconfig%2Fexecutor%2FClusterConfigTaskExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9leGVjdXRpb24vY29uZmlnL2V4ZWN1dG9yL0NsdXN0ZXJDb25maWdUYXNrRXhlY3V0b3IuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...b/commons/pipe/sink/client/IoTDBClientManager.java](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Fsink%2Fclient%2FIoTDBClientManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9zaW5rL2NsaWVudC9Jb1REQkNsaWVudE1hbmFnZXIuamF2YQ==) | 40.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/iotdb/pull/17869?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17869 +/- ##
============================================
+ Coverage 40.95% 41.12% +0.17%
Complexity 318 318
============================================
Files 5248 5254 +6
Lines 364224 364810 +586
Branches 47043 47096 +53
============================================
+ Hits 149155 150039 +884
+ Misses 215069 214771 -298
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/17869?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4764165082
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=0f2eeca128cdb591a3c21ced893a5d80941fd7157db4b6022c66edc3b81f6ffd -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4705546394
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=d38069f65d242ef907ea4bdf5b39a1a2170f7e2742345cb6c8a78e7d9a80c910 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4739394300
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=93563f3ec05886eb87343783cc3ad8d306e1df9038d97e91f633b181cc33ba96 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-5326146552
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=281f5949f243e293350692997abc82d298d4401c0fc60220c142c52250d6425a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4714936133
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=08b4b8eb43ca419d374c7ca3094e2f3f7a133d1f48e3ed7f288ecc87e1e28a6a -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4706535961
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=c721c67aca31e84f0274ae25025b61ca214d6871b1457fe409e918a6de6a24fa -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-5404592901
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=1a6585e81655104da5cf023a7f65023f4cdb0cbf7be6cc746d7fbd1738274e74 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #17869:
URL: https://github.com/apache/iotdb/pull/17869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4764475317
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=0f2eeca128cdb591a3c21ced893a5d80941fd7157db4b6022c66edc3b81f6ffd -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4686574542
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=56575c4f113ec38768c8770cfa39c2d07adaf585c4aa1949490da0193d8a9def -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SHOW RECEIVERS support [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17869:
URL: https://github.com/apache/iotdb/pull/17869#issuecomment-4778825001
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869) (required ≥ A)
<!-- sqra:qg_revision=0f2eeca128cdb591a3c21ced893a5d80941fd7157db4b6022c66edc3b81f6ffd -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17869)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org