You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Alex Blewitt <al...@gmail.com> on 2007/01/10 01:56:00 UTC
[classlib][pack200] Updated project and build
I've fixed the pack200 project to compile against 1.4 now, so with any
luck we won't get the annotations coming in the future.
One thing I did notice was that when I was submitting a Jar (stubs of
1.5 required classes outside of a 1.5 system) the svn diff didn't
create the contents. The patch just read:
Index: /Users/alex/Documents/Harmony/Workspace/Harmony/trunk/modules/pack200/pac
k200-java5.jar
===================================================================
Cannot display: file marked as a binary type.
I'm pretty sure that would make the patch unappliable at the other
end, so I attatched it manually. Is there any way of getting the SVN
diff to generate some kind of UUEncoded form of the binary data? Or do
I have to do this with all non-text types in the future?
Alex.
Re: Re: Re: [classlib][pack200] Updated project and build
Posted by Alex Blewitt <al...@gmail.com>.
On 11/01/07, Tony Wu <wu...@gmail.com> wrote:
> how about refer your jar file as a dependency, like yoko does?
> when you need update the file, you do not have to submit a new one but
> create a patch for modified properties.xml
The classes in the Jar are integral to the part of the pack200 for
those that want to use it externally to harmony. That's a no-go
option. In any case, I've not finished implementing them yet :-)
Alex
Re: Re: [classlib][pack200] Updated project and build
Posted by Tony Wu <wu...@gmail.com>.
how about refer your jar file as a dependency, like yoko does?
when you need update the file, you do not have to submit a new one but
create a patch for modified properties.xml
On 1/11/07, Alex Blewitt <al...@gmail.com> wrote:
> On 10/01/07, Tim Ellison <t....@gmail.com> wrote:
> > Alex Blewitt wrote:
> > >
> > > One thing I did notice was that when I was submitting a Jar (stubs of
> > > 1.5 required classes outside of a 1.5 system) the svn diff didn't
> > > create the contents. The patch just read:
> >
> > Attaching the file to the JIRA, or zipping a bunch of files to be added
> > together, has been the way to date. Some kind folk even provide the svn
> > add/move script or a set of instructions for applying it.
>
> Yeah, that's what I did in the end. I was just surprised that the svn
> diff didn't actually do a diff of binary files; that almost certainly
> explains some of the earlier failures in applying of the patches; I
> was assuming the patch contained the binary files, whereas it didn't.
>
> It also means that when adding binary files (e.g. the test data for
> the packed Jars) I need to be careful that I remember to add any
> binary files that I've changed. :-(
>
> Alex.
>
--
Tony Wu
China Software Development Lab, IBM
Re: Re: [classlib][pack200] Updated project and build
Posted by Alex Blewitt <al...@gmail.com>.
On 10/01/07, Tim Ellison <t....@gmail.com> wrote:
> Alex Blewitt wrote:
> >
> > One thing I did notice was that when I was submitting a Jar (stubs of
> > 1.5 required classes outside of a 1.5 system) the svn diff didn't
> > create the contents. The patch just read:
>
> Attaching the file to the JIRA, or zipping a bunch of files to be added
> together, has been the way to date. Some kind folk even provide the svn
> add/move script or a set of instructions for applying it.
Yeah, that's what I did in the end. I was just surprised that the svn
diff didn't actually do a diff of binary files; that almost certainly
explains some of the earlier failures in applying of the patches; I
was assuming the patch contained the binary files, whereas it didn't.
It also means that when adding binary files (e.g. the test data for
the packed Jars) I need to be careful that I remember to add any
binary files that I've changed. :-(
Alex.
Re: [classlib][pack200] Updated project and build
Posted by Tim Ellison <t....@gmail.com>.
Alex Blewitt wrote:
> I've fixed the pack200 project to compile against 1.4 now, so with any
> luck we won't get the annotations coming in the future.
>
> One thing I did notice was that when I was submitting a Jar (stubs of
> 1.5 required classes outside of a 1.5 system) the svn diff didn't
> create the contents. The patch just read:
>
> Index:
> /Users/alex/Documents/Harmony/Workspace/Harmony/trunk/modules/pack200/pac
> k200-java5.jar
> ===================================================================
> Cannot display: file marked as a binary type.
>
> I'm pretty sure that would make the patch unappliable at the other
> end, so I attatched it manually. Is there any way of getting the SVN
> diff to generate some kind of UUEncoded form of the binary data? Or do
> I have to do this with all non-text types in the future?
Attaching the file to the JIRA, or zipping a bunch of files to be added
together, has been the way to date. Some kind folk even provide the svn
add/move script or a set of instructions for applying it.
Regards,
Tim
Re: Re: [classlib][pack200] Updated project and build
Posted by Alex Blewitt <al...@gmail.com>.
If you mean 'that jar to mean the pack200-java5, yes, the source is
included. In fact, I've defined it as a separate source folder, and
the build.xml actually compiles those source files and merges the
contents into the generated pack200.jar and pack200-src.jar. They're
just compiled with the appropriate targets.
So the existence of the .jar is really just to support running in the
IDE. I've also added comments in the README about it.
Alex.
On 10/01/07, Geir Magnusson Jr. <ge...@pobox.com> wrote:
>
> FTR, is the source and build instructions around for that jar? It
> isn't a "primary form" like a .jpg is, so we probably should get the
> source in too, even if we keep the jar around for convenience.
>
> geir
>
>
Re: [classlib][pack200] Updated project and build
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
On Jan 9, 2007, at 7:56 PM, Alex Blewitt wrote:
> I've fixed the pack200 project to compile against 1.4 now, so with any
> luck we won't get the annotations coming in the future.
>
> One thing I did notice was that when I was submitting a Jar (stubs of
> 1.5 required classes outside of a 1.5 system) the svn diff didn't
> create the contents. The patch just read:
>
> Index: /Users/alex/Documents/Harmony/Workspace/Harmony/trunk/
> modules/pack200/pac
> k200-java5.jar
> ===================================================================
> Cannot display: file marked as a binary type.
>
> I'm pretty sure that would make the patch unappliable at the other
> end, so I attatched it manually. Is there any way of getting the SVN
> diff to generate some kind of UUEncoded form of the binary data? Or do
> I have to do this with all non-text types in the future?
FTR, is the source and build instructions around for that jar? It
isn't a "primary form" like a .jpg is, so we probably should get the
source in too, even if we keep the jar around for convenience.
geir