You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/18 08:12:41 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5675: server bug fix: remove network details when network is removed

DaanHoogland commented on a change in pull request #5675:
URL: https://github.com/apache/cloudstack/pull/5675#discussion_r751993563



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -3116,6 +3116,8 @@ public void doInTransactionWithoutResult(final TransactionStatus status) {
                                 if (networkAccount != null) {
                                     _networkAccountDao.remove(networkAccount.getId());
                                 }
+                                // Remove network details

Review comment:
       I don't think this comment is needed, given the name of the method invoked




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org