You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/05 06:47:44 UTC

[PR] test(amber): add AsyncRPCClient unit tests for createInvocation and logControlReply [texera]

aglinxinyuan opened a new pull request, #6139:
URL: https://github.com/apache/texera/pull/6139

   ### What changes were proposed in this PR?
   
   Adds a unit test for `AsyncRPCClient` (`amber` engine RPC), which had no dedicated spec. The test drives the client with directly-constructed collaborators (a real `NetworkInputGateway` and a `NetworkOutputGateway` whose handler captures messages) — no actor system, DB, or network — and covers the currently-uncovered paths:
   
   - `createInvocation` — carries method name/context, hands back an unfulfilled future, assigns monotonic command IDs, and `fulfillPromise` completes the future with the return value (and fails it on a `ControlError`);
   - `logControlReply` — all four branches: the `IgnoreReplyAndDoNotLog` early-return, the metrics early-return, the `ControlError` error path, and the null-`returnValue` info path;
   - `sendToClient` — forwards exactly one message to the client channel.
   
   No production code is changed; this is test-only.
   
   ### Any related issues, documentation, discussions?
   
   Coverage gaps identified from the Codecov report for `apache/texera`.
   
   ### How was this PR tested?
   
   New ScalaTest spec, run locally:
   
   ```
   sbt "WorkflowExecutionService/testOnly *AsyncRPCClientSpec"
   ```
   
   All 11 pass. `scalafmt` and `scalafixAll --check` are clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(amber): add AsyncRPCClient unit tests for createInvocation and logControlReply [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6139:
URL: https://github.com/apache/texera/pull/6139#issuecomment-4885146775

   ### :warning: JUnit XML file not found
   The CLI was unable to find any JUnit XML files to upload.
   For more help, visit our [troubleshooting guide](https://docs.codecov.com/docs/test-analytics#troubleshooting).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(amber): add AsyncRPCClient unit tests for createInvocation and logControlReply [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6139:
URL: https://github.com/apache/texera/pull/6139#issuecomment-4885139025

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - No candidates found from `git blame` history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(amber): add AsyncRPCClient unit tests for createInvocation and logControlReply [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6139:
URL: https://github.com/apache/texera/pull/6139#issuecomment-4885146368

   <!-- texera-benchmarks-comment -->
   ## 📊 Arrow Flight E2E bench
   
   _(no arrow-flight-e2e.csv in artifact)_
   
   [Full dashboard](https://apache.github.io/texera/dev/bench/) · [Workflow run](https://github.com/apache/texera/actions/runs/28732425041)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(amber): add AsyncRPCClient unit tests for createInvocation and logControlReply [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6139:
URL: https://github.com/apache/texera/pull/6139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org