[GitHub] [netbeans] sdedic commented on a change in pull request #2859: [NETBEANS-5522] Minimal support for Gradle 7.0

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #2859:
URL: https://github.com/apache/netbeans/pull/2859#discussion_r610915538



##########
File path: extide/gradle/netbeans-gradle-tooling/src/main/groovy/org/netbeans/modules/gradle/tooling/NbProjectInfoBuilder.groovy
##########
@@ -258,8 +258,10 @@ class NbProjectInfoBuilder {
                             model.info["sourceset_${sourceSet.name}_classpath_annotation"] = storeSet(sourceSet.compileClasspath.files)
                         }
                     }
-                    model.info["sourceset_${sourceSet.name}_configuration_compile"] = sourceSet.compileConfigurationName;
-                    model.info["sourceset_${sourceSet.name}_configuration_runtime"] = sourceSet.runtimeConfigurationName;
+                    beforeGradle('7.0') {
+                        model.info["sourceset_${sourceSet.name}_configuration_compile"] = sourceSet.compileConfigurationName;

Review comment:
       I've tried to find where this information is used in gradle project, but I've found no references to `GradleJavaSourceSet.getRuntimeConfigurationName()` ?
   Is this information superseded by something or maybe should be the `getRuntimeConfigurationName()` annotated as `@deprecated` as they won't provide useful info for Gradle >= 7?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists