You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2014/12/13 02:09:13 UTC
[jira] [Updated] (SAMZA-163) Remove mutable.ConcurrentMap when we
stop supporting 2.9
[ https://issues.apache.org/jira/browse/SAMZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated SAMZA-163:
------------------------------
Attachment: SAMZA-163.patch
2.9 support was removed in SAMZA-430, therefore we can remove this.
Attaching small patch to do so. Also wipes out the warnings that have crept into the code re: unchecked warnings and shadowed imports. Ran check-all, all was checked and appeared good.
No rb since is simple.
> Remove mutable.ConcurrentMap when we stop supporting 2.9
> --------------------------------------------------------
>
> Key: SAMZA-163
> URL: https://issues.apache.org/jira/browse/SAMZA-163
> Project: Samza
> Issue Type: Improvement
> Components: kafka
> Affects Versions: 0.8.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.9.0
>
> Attachments: SAMZA-163.patch
>
>
> ./gradlew check throws up multiple warnings from the nextOffsets map in BrokerProxy:
> {noformat}
> .../BrokerProxy.scala:68: warning: trait ConcurrentMap in package mutable is deprecated: Use `scala.collection.concurrent.Map` instead.
> val nextOffsets:mutable.ConcurrentMap[TopicAndPartition, Long] = new ConcurrentHashMap[TopicAndPartition, Long]()
> {noformat}
> We can't do the suggested fix since scala.collect.concurrent.Map doesn't exist in 2.9, but once we're done with 2.9 we should take a look at this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)