You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by Julian Feinauer <j....@pragmaticminds.de> on 2018/09/02 07:52:03 UTC

[S7] TransportSize Enum Code

Hi all,

as I’m going forward refactoring the S7 Driver I have one question about the „code“ field in the TransportSize enum.
For me it seems as this code is type related, i.e., is unique for each “S7Type”.
Furthermore, the number of bytes should be redundant to the bitWIdth ( / 8), except for “edge case” like Timers.

As I’m implementing especially “unsigned” types I would like to know wheter they share the “code” with their signed versions or if we have to extract them separately.

Could someone who implemented this (chris?) give me some infos about that?

Thanks!
Julian

Re: [S7] TransportSize Enum Code

Posted by Christofer Dutz <ch...@c-ware.de>.

Hi Julian,

TransportSize is sort of the old version of the S7DataType and will be replaced by this. 

Remember that I added the S7DataType class and is wasn't referenced by any code as I wanted some feedback? ... so just ignore the TransportSize type ... we'll probably also rename and move the S7DataType as part of this refactoring. 

Regarding your bitWidth question ... could you point me to where that is used? I couldn't find it.

Chris



Am 02.09.18, 09:52 schrieb "Julian Feinauer" <j....@pragmaticminds.de>:

    Hi all,
    
    as I’m going forward refactoring the S7 Driver I have one question about the „code“ field in the TransportSize enum.
    For me it seems as this code is type related, i.e., is unique for each “S7Type”.
    Furthermore, the number of bytes should be redundant to the bitWIdth ( / 8), except for “edge case” like Timers.
    
    As I’m implementing especially “unsigned” types I would like to know wheter they share the “code” with their signed versions or if we have to extract them separately.
    
    Could someone who implemented this (chris?) give me some infos about that?
    
    Thanks!
    Julian