Re: [I] Superset worker has no lifecycle preStop command [superset]

["mjlshen (via GitHub)" <gi...@apache.org>]

mjlshen commented on issue #33513:
URL: https://github.com/apache/superset/issues/33513#issuecomment-4735971688

   Just chiming in from essentially the same issue I found in the Superset webserver not gracefully shutting down - tl;dr this guess earlier from @otunyk-smtc was/is true:
   > It is also possible that Kubernetes sends SIGTERM to PID 1 in the container when terminating a pod, and SIGTERM is not propagated from entrypoint to celery worker master PID 7, if that is the case then it explains why celery worker graceful shutdown is not working as expected.
   
   I have a fix for the webserver #41173 and worker #41175 to correctly use `exec` to elevate gunicorn/celery to PID 1 so that they receive SIGTERM correctly. I also included the ability to override lifecycle and gracefulTerminationPeriodSeconds moving forward so that larger setups can more fully customize how long SIGTERMs should take (`gracefulTerminationPeriodSeconds` defaults to 30s on Kubernetes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org