You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "emiliosetiadarma (via GitHub)" <gi...@apache.org> on 2023/12/05 22:05:28 UTC
[PR] NIFI-12474: remove TriggerWhenEmpty for DeleteHDFS [nifi]
emiliosetiadarma opened a new pull request, #8125:
URL: https://github.com/apache/nifi/pull/8125
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-12474](https://issues.apache.org/jira/browse/NIFI-12474)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12474: remove TriggerWhenEmpty for DeleteHDFS [nifi]
Posted by "emiliosetiadarma (via GitHub)" <gi...@apache.org>.
emiliosetiadarma commented on code in PR #8125:
URL: https://github.com/apache/nifi/pull/8125#discussion_r1424253228
##########
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java:
##########
@@ -139,6 +137,7 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
// If this processor has an incoming connection, then do not run unless a
// FlowFile is actually sent through
if (originalFlowFile == null && context.hasIncomingConnection()) {
+ context.yield();
Review Comment:
That makes sense.. going to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12474: remove TriggerWhenEmpty for DeleteHDFS [nifi]
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende commented on code in PR #8125:
URL: https://github.com/apache/nifi/pull/8125#discussion_r1424091461
##########
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java:
##########
@@ -139,6 +137,7 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
// If this processor has an incoming connection, then do not run unless a
// FlowFile is actually sent through
if (originalFlowFile == null && context.hasIncomingConnection()) {
+ context.yield();
Review Comment:
I don't think we need to add the `yield()` back right?
Since we are removing `@TriggerWhenEmpty` the only way we can now get a null flow file would be a concurrent task execution where one task executes the processor at a split second where another task executed and grabbed the flow file. In this case we don't need/want to yield.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12474: remove TriggerWhenEmpty for DeleteHDFS [nifi]
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende merged PR #8125:
URL: https://github.com/apache/nifi/pull/8125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org