You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/31 06:40:10 UTC

[GitHub] [spark] beliefer opened a new pull request, #37736: [SPARK-40285][SQL] Simplify the roundTo[Numeric] for Decimal

beliefer opened a new pull request, #37736:
URL: https://github.com/apache/spark/pull/37736

   ### What changes were proposed in this pull request?
   Simplify the `roundTo[Numeric]` for Spark `Decimal`.
   
   
   ### Why are the changes needed?
   Spark `Decimal` have a lot of methods named `roundTo[*]`.
   Except `roundToLong`, everything else is redundant.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   Just simplify the inner implementation.
   
   
   ### How was this patch tested?
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #37736: [SPARK-40285][SQL] Simplify the `roundTo[Numeric]` for Spark `Decimal`

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #37736:
URL: https://github.com/apache/spark/pull/37736#issuecomment-1233689147

   ping @MaxGekk @dongjoon-hyun @gengliangwang @viirya @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #37736: [SPARK-40285][SQL] Simplify the `roundTo[Numeric]` for Spark `Decimal`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37736:
URL: https://github.com/apache/spark/pull/37736#issuecomment-1233732666

   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #37736: [SPARK-40285][SQL] Simplify the `roundTo[Numeric]` for Spark `Decimal`

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #37736:
URL: https://github.com/apache/spark/pull/37736#issuecomment-1233738789

   @cloud-fan Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #37736: [SPARK-40285][SQL] Simplify the `roundTo[Numeric]` for Spark `Decimal`

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #37736: [SPARK-40285][SQL] Simplify the `roundTo[Numeric]` for Spark `Decimal`
URL: https://github.com/apache/spark/pull/37736


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org