You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/21 07:59:31 UTC
[GitHub] [apisix] gy09535 opened a new pull request #2094: feature: added to limit req based on the request header and request parameters.
gy09535 opened a new pull request #2094:
URL: https://github.com/apache/apisix/pull/2094
### What this PR does / why we need it:
we can use request parameters and headers to limit req.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 closed pull request #2094: feature: added to limit req based on the request header and request parameters.
Posted by GitBox <gi...@apache.org>.
gy09535 closed pull request #2094:
URL: https://github.com/apache/apisix/pull/2094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2094: feature: added to limit req based on the request header and request parameters.
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2094:
URL: https://github.com/apache/apisix/pull/2094#issuecomment-678111521
> @gy09535 Apache APISIX already support all nginx variables as limit key: http://nginx.org/en/docs/varindex.html, you just need to add it in the enum list of key: https://github.com/apache/apisix/blob/master/apisix/plugins/limit-req.lua#L29.
It's a good idea to write in the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2094: feature: added to limit req based on the request header and request parameters.
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2094:
URL: https://github.com/apache/apisix/pull/2094#issuecomment-678111148
@gy09535 Apache APISIX already support all nginx variables as limit key: http://nginx.org/en/docs/varindex.html, you just need to add it in the enum list of key: https://github.com/apache/apisix/blob/master/apisix/plugins/limit-req.lua#L29.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 removed a comment on pull request #2094: feature: added to limit req based on the request header and request parameters.
Posted by GitBox <gi...@apache.org>.
gy09535 removed a comment on pull request #2094:
URL: https://github.com/apache/apisix/pull/2094#issuecomment-686994579
Sentinel has implementation this requirement. according to https://github.com/alibaba/Sentinel/wiki/%E7%BD%91%E5%85%B3%E9%99%90%E6%B5%81#%E7%BD%91%E5%85%B3%E6%B5%81%E6%8E%A7%E6%8E%A7%E5%88%B6%E5%8F%B0, I think it is very useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on pull request #2094: feature: added to limit req based on the request header and request parameters.
Posted by GitBox <gi...@apache.org>.
gy09535 commented on pull request #2094:
URL: https://github.com/apache/apisix/pull/2094#issuecomment-686995842
> > @gy09535 Apache APISIX already support all nginx variables as limit key: http://nginx.org/en/docs/varindex.html, you just need to add it in the enum list of key: https://github.com/apache/apisix/blob/master/apisix/plugins/limit-req.lua#L29.
>
> It's a good idea to write in the doc.
Sentinel has implementation this requirement. according to https://github.com/alibaba/Sentinel/wiki/%E7%BD%91%E5%85%B3%E9%99%90%E6%B5%81#%E7%BD%91%E5%85%B3%E6%B5%81%E6%8E%A7%E6%8E%A7%E5%88%B6%E5%8F%B0, I think it is very useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on pull request #2094: feature: added to limit req based on the request header and request parameters.
Posted by GitBox <gi...@apache.org>.
gy09535 commented on pull request #2094:
URL: https://github.com/apache/apisix/pull/2094#issuecomment-686994579
Sentinel has implementation this requirement. according to https://github.com/alibaba/Sentinel/wiki/%E7%BD%91%E5%85%B3%E9%99%90%E6%B5%81#%E7%BD%91%E5%85%B3%E6%B5%81%E6%8E%A7%E6%8E%A7%E5%88%B6%E5%8F%B0, I think it is very useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org