You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/05 12:16:15 UTC

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1466: HDDS-4271. Avoid logging chunk content in Ozone Insight

adoroszlai commented on pull request #1466:
URL: https://github.com/apache/hadoop-ozone/pull/1466#issuecomment-703593031


   Thanks @elek for reviewing and committing this.
   
   > My only counterargument is that it makes the debug slightly slower (and not only the TRACE but DEBUG as well).
   
   I don't see why, as `requestPreprocessor` is only called in the trace branch.
   
   https://github.com/apache/hadoop-ozone/blob/cfff0973d4567185532078daa4cd19ee8a4b04b5/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/OzoneProtocolMessageDispatcher.java#L74-L83


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org