You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Shawn Jiang (JIRA)" <ji...@apache.org> on 2009/09/10 08:51:57 UTC

[jira] Issue Comment Edited: (GERONIMO-4858) Geronimo 2.2 doesn't add correct connector attributes to server.xml

    [ https://issues.apache.org/jira/browse/GERONIMO-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753460#action_12753460 ] 

Shawn Jiang edited comment on GERONIMO-4858 at 9/9/09 11:51 PM:
----------------------------------------------------------------

Patch committed to 22 branch and trunk with little changes. Thanks Siqi for the patch.

Siqi, please use 4 space as tab instead of using tab directly in the code.  Thanks.

      was (Author: genspring):
    Patch committed to 22 branch and trunk with little changes. Thanks Siqi for the patch.

Siqi, please don't use 4 space as tab instead of using tab directly in the code.  Thanks.
  
> Geronimo 2.2 doesn't add correct connector attributes to server.xml
> -------------------------------------------------------------------
>
>                 Key: GERONIMO-4858
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4858
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: connector, console
>    Affects Versions: 2.2, 3.0
>            Reporter: Quintin Beukes
>            Assignee: Shawn Jiang
>            Priority: Critical
>             Fix For: 2.2
>
>         Attachments: tomcat.patch
>
>
> OK. So I extract the 2009-09-08 nightly snapshot (tomcat binary), and deploy some repository JARs, a datasource and a security realm. Then I goto Web Server portlet and create a new Tomcat BIO connector. I enter a name, and for port I enter 80. This is a rough of the steps I took from a clean install.
> So the bug is that when you add a connector, it immediately starts it on the correct port (as can be seen with netstat), but it saves to var/catalina/server.xml with port 8080. So once you restart the server you receive a port conflict if you have another 8080, and if you don't it would be like you never made the change, with your connector reverting to 8080.
> Here is a snippet of what it saves after adding a port "801" BIO connector:
> <Connector connectionTimeout="60000" executor="DefaultThreadPool" name="testConnector1" port="8080" protocol="HTTP/1.1" redirectPort="8443" server=""/>
> Q

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Issue Comment Edited: (GERONIMO-4858) Geronimo 2.2 doesn't add correct connector attributes to server.xml

Posted by Siqi Du <si...@gmail.com>.
[?]Got it. Thank you, Shawn.

On Thu, Sep 10, 2009 at 2:51 PM, Shawn Jiang (JIRA) <ji...@apache.org> wrote:

>
>    [
> https://issues.apache.org/jira/browse/GERONIMO-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753460#action_12753460]
>
> Shawn Jiang edited comment on GERONIMO-4858 at 9/9/09 11:51 PM:
> ----------------------------------------------------------------
>
> Patch committed to 22 branch and trunk with little changes. Thanks Siqi for
> the patch.
>
> Siqi, please use 4 space as tab instead of using tab directly in the code.
>  Thanks.
>
>      was (Author: genspring):
>    Patch committed to 22 branch and trunk with little changes. Thanks Siqi
> for the patch.
>
> Siqi, please don't use 4 space as tab instead of using tab directly in the
> code.  Thanks.
>
> > Geronimo 2.2 doesn't add correct connector attributes to server.xml
> > -------------------------------------------------------------------
> >
> >                 Key: GERONIMO-4858
> >                 URL: https://issues.apache.org/jira/browse/GERONIMO-4858
> >             Project: Geronimo
> >          Issue Type: Bug
> >      Security Level: public(Regular issues)
> >          Components: connector, console
> >    Affects Versions: 2.2, 3.0
> >            Reporter: Quintin Beukes
> >            Assignee: Shawn Jiang
> >            Priority: Critical
> >             Fix For: 2.2
> >
> >         Attachments: tomcat.patch
> >
> >
> > OK. So I extract the 2009-09-08 nightly snapshot (tomcat binary), and
> deploy some repository JARs, a datasource and a security realm. Then I goto
> Web Server portlet and create a new Tomcat BIO connector. I enter a name,
> and for port I enter 80. This is a rough of the steps I took from a clean
> install.
> > So the bug is that when you add a connector, it immediately starts it on
> the correct port (as can be seen with netstat), but it saves to
> var/catalina/server.xml with port 8080. So once you restart the server you
> receive a port conflict if you have another 8080, and if you don't it would
> be like you never made the change, with your connector reverting to 8080.
> > Here is a snippet of what it saves after adding a port "801" BIO
> connector:
> > <Connector connectionTimeout="60000" executor="DefaultThreadPool"
> name="testConnector1" port="8080" protocol="HTTP/1.1" redirectPort="8443"
> server=""/>
> > Q
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>