You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/21 03:04:34 UTC

[GitHub] [spark] yaooqinn opened a new pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

yaooqinn opened a new pull request #30113:
URL: https://github.com/apache/spark/pull/30113


   ### What changes were proposed in this pull request?
   
   Address comments @ https://github.com/apache/spark/pull/29635#discussion_r507241899 to improve migration guide
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   improve migration guide
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   NO,only doc update
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   passing GitHub action


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713350899


   This is trivial, so I merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713269721


   **[Test build #130065 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130065/testReport)** for PR 30113 at commit [`d458e81`](https://github.com/apache/spark/commit/d458e81985a5bd9624869130086ef25b99dffd50).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713291011


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34674/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713265854


   **[Test build #130065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130065/testReport)** for PR 30113 at commit [`d458e81`](https://github.com/apache/spark/commit/d458e81985a5bd9624869130086ef25b99dffd50).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713266349


   cc @maropu @gatorsmile ~ thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu closed pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
maropu closed pull request #30113:
URL: https://github.com/apache/spark/pull/30113


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713291028






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713265854


   **[Test build #130065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130065/testReport)** for PR 30113 at commit [`d458e81`](https://github.com/apache/spark/commit/d458e81985a5bd9624869130086ef25b99dffd50).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713280580


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34674/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713350333


   OK~ I will backport this after it gets merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713269865






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713349777


   @yaooqinn Thanks for the fix and could you fix it in branch-3.0, too?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713269865






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30113: [SPARK-32785][SQL][DOCS][FOLLOWUP] Update migaration guide for incomplete interval literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30113:
URL: https://github.com/apache/spark/pull/30113#issuecomment-713291028






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org