You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/09/17 10:46:18 UTC
[GitHub] [hbase] richardantal opened a new pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
richardantal opened a new pull request #3688:
URL: https://github.com/apache/hbase/pull/3688
…results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-927839810
Sorry, haven't gotten enough time to do this, a bit busy recently...
Let me just open a new PR without UT to see the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-924936011
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 22s | master passed |
| +1 :green_heart: | compile | 1m 12s | master passed |
| +1 :green_heart: | shadedjars | 8m 11s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 20s | the patch passed |
| +1 :green_heart: | compile | 1m 14s | the patch passed |
| +1 :green_heart: | javac | 1m 14s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 12s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 143m 38s | hbase-server in the patch passed. |
| | | 175m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 93c71a577350 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96fa015043 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/testReport/ |
| Max. process+thread count | 4409 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
petersomogyi commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r714039772
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+
+@Category({RestTests.class, MediumTests.class})
Review comment:
This is not a Rest related test, please remote that Category.
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
Review comment:
This seems unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929256538
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 24s | master passed |
| +1 :green_heart: | compile | 3m 23s | master passed |
| +1 :green_heart: | checkstyle | 1m 11s | master passed |
| +1 :green_heart: | spotbugs | 2m 13s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 8s | the patch passed |
| +1 :green_heart: | compile | 3m 23s | the patch passed |
| +1 :green_heart: | javac | 3m 23s | the patch passed |
| -0 :warning: | checkstyle | 1m 9s | hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 20m 26s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 52m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 037043b94266 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / cbebf85b3c |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929665036
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 14s | master passed |
| +1 :green_heart: | compile | 3m 26s | master passed |
| +1 :green_heart: | checkstyle | 1m 10s | master passed |
| +1 :green_heart: | spotbugs | 2m 16s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 3s | the patch passed |
| +1 :green_heart: | compile | 3m 21s | the patch passed |
| +1 :green_heart: | javac | 3m 21s | the patch passed |
| -0 :warning: | checkstyle | 1m 8s | hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 20m 27s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 24s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 52m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9244e73aff04 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 113cc2a591 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 85 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi merged pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
petersomogyi merged pull request #3688:
URL: https://github.com/apache/hbase/pull/3688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r717974995
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -757,7 +757,7 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws
}
} while ((cell = this.heap.peek()) != null);
- if (count > 0) {
+ if (count > 0 || (storeLimit > -1 && this.countPerRow > (storeLimit + storeOffset))) {
Review comment:
No, I just forget to delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929117442
Thats good news. OK, let's use that approach.
Thanks @Apache9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925955478
@Apache9 That makes sense.
I tested your change, also validated the number of cells returned for each row and it seems fine.
Anyway lets wait all the UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-927837458
@Apache9 have you checked if there is any side effect because of your change?
What was the outcome of the UTs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-924846787
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 25s | master passed |
| +1 :green_heart: | compile | 3m 20s | master passed |
| +1 :green_heart: | checkstyle | 1m 11s | master passed |
| +1 :green_heart: | spotbugs | 2m 14s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 7s | the patch passed |
| +1 :green_heart: | compile | 3m 24s | the patch passed |
| +1 :green_heart: | javac | 3m 24s | the patch passed |
| -0 :warning: | checkstyle | 1m 12s | hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 20m 37s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 28s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 58m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ea4309c8ba91 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96fa015043 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925139467
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 9s | master passed |
| +1 :green_heart: | compile | 3m 19s | master passed |
| +1 :green_heart: | checkstyle | 1m 10s | master passed |
| +1 :green_heart: | spotbugs | 2m 10s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 4s | the patch passed |
| +1 :green_heart: | compile | 3m 23s | the patch passed |
| +1 :green_heart: | javac | 3m 23s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 10s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 20m 26s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 28s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 52m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 87ec006b065b 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d956828aac |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925098992
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 5s | master passed |
| +1 :green_heart: | compile | 1m 1s | master passed |
| +1 :green_heart: | shadedjars | 8m 11s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 42s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 10s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 148m 29s | hbase-server in the patch passed. |
| | | 178m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 733cd163e4fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96fa015043 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/testReport/ |
| Max. process+thread count | 4319 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925826266
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 29s | master passed |
| +1 :green_heart: | compile | 1m 11s | master passed |
| +1 :green_heart: | shadedjars | 8m 12s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 43s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 12s | the patch passed |
| +1 :green_heart: | compile | 1m 13s | the patch passed |
| +1 :green_heart: | javac | 1m 13s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 12s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 40s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 139m 57s | hbase-server in the patch passed. |
| | | 171m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b2726ccea512 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d956828aac |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/testReport/ |
| Max. process+thread count | 3703 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925039488
Thank you @petersomogyi for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925826121
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 44s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 11s | master passed |
| +1 :green_heart: | compile | 1m 13s | master passed |
| +1 :green_heart: | shadedjars | 9m 30s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 6s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 21s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 162m 28s | hbase-server in the patch passed. |
| | | 196m 7s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux a89e6d421f38 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d956828aac |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/testReport/ |
| Max. process+thread count | 4342 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925271703
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 42s | master passed |
| +1 :green_heart: | compile | 1m 1s | master passed |
| +1 :green_heart: | shadedjars | 8m 11s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 50s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 12s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 148m 7s | hbase-server in the patch passed. |
| | | 178m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 141a0e10b256 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d956828aac |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/testReport/ |
| Max. process+thread count | 3900 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-927843659
Alright, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925708987
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 31s | master passed |
| +1 :green_heart: | compile | 4m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 17s | master passed |
| +1 :green_heart: | spotbugs | 2m 28s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 52s | the patch passed |
| +1 :green_heart: | compile | 3m 21s | the patch passed |
| +1 :green_heart: | javac | 3m 21s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 3s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 19m 54s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 52m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 788c8ae4c96e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d956828aac |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 95 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/6/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925854591
I tried to move this block of code
```
if (storeLimit > -1 && this.countPerRow >= (storeLimit + storeOffset)) {
// do what SEEK_NEXT_ROW does.
if (!matcher.moreRowsMayExistAfter(cell)) {
close(false);// Do all cleanup except heap.close()
return scannerContext.setScannerState(NextState.NO_MORE_VALUES).hasMoreValues();
}
matcher.clearCurrentRow();
seekToNextRow(cell);
break LOOP;
}
```
Into the `if (this.countPerRow > storeOffset) {` block, at the last of this if block.
And also, changed the condition from `this.countPerRow > (storeLimit + storeOffset)` to `this.countPerRow >= (storeLimit + storeOffset)`. It could also pass the added UT.
Not sure if there are other side effects... Let me try to run all the UTs with this patch.
For me, it is a bit strange that why we need to read an extra cell and then drop it, why not just break the LOOP when we get enough cells. That's why I changed the condition from > to >=.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r713898046
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
Review comment:
No, it should be fine with 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r717974995
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -757,7 +757,7 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws
}
} while ((cell = this.heap.peek()) != null);
- if (count > 0) {
+ if (count > 0 || (storeLimit > -1 && this.countPerRow > (storeLimit + storeOffset))) {
Review comment:
No, I just forget to delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-921805437
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 25s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 46s | master passed |
| +1 :green_heart: | compile | 1m 14s | master passed |
| +1 :green_heart: | shadedjars | 8m 30s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 44s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 19s | the patch passed |
| +1 :green_heart: | compile | 1m 17s | the patch passed |
| +1 :green_heart: | javac | 1m 17s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 25s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 140m 12s | hbase-server in the patch passed. |
| | | 172m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c4463c88e8c9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c60adfd13a |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/testReport/ |
| Max. process+thread count | 4067 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-921739087
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 45s | master passed |
| +1 :green_heart: | compile | 5m 33s | master passed |
| +1 :green_heart: | checkstyle | 1m 30s | master passed |
| +1 :green_heart: | spotbugs | 3m 30s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 55s | the patch passed |
| -1 :x: | compile | 4m 28s | hbase-server in the patch failed. |
| -0 :warning: | javac | 4m 28s | hbase-server in the patch failed. |
| +1 :green_heart: | checkstyle | 1m 33s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 27m 3s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 3m 18s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 70m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3a4bcaed37c2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c60adfd13a |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r717696072
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -757,7 +757,7 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws
}
} while ((cell = this.heap.peek()) != null);
- if (count > 0) {
+ if (count > 0 || (storeLimit > -1 && this.countPerRow > (storeLimit + storeOffset))) {
Review comment:
We do not need to add this extra check any more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929114611
The pre commit result in #3701 seems alright. So let's use the new approach? OK by you @richardantal ?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-924987405
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 4s | master passed |
| +1 :green_heart: | compile | 3m 9s | master passed |
| +1 :green_heart: | checkstyle | 1m 5s | master passed |
| +1 :green_heart: | spotbugs | 2m 7s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 44s | the patch passed |
| +1 :green_heart: | compile | 3m 9s | the patch passed |
| +1 :green_heart: | javac | 3m 9s | the patch passed |
| -0 :warning: | checkstyle | 1m 2s | hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 12s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 47m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7c48453ff3c0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96fa015043 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 95 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-924941408
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 6s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 41s | master passed |
| +1 :green_heart: | compile | 1m 0s | master passed |
| +1 :green_heart: | shadedjars | 8m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 44s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 10s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 148m 20s | hbase-server in the patch passed. |
| | | 181m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c9930e4d8a7a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96fa015043 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/testReport/ |
| Max. process+thread count | 4957 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r711109097
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamily() throws Exception {
+ Admin admin = hbaseTestingUtility.getAdmin();
+ TableName tableName = TableName.valueOf("TestScannersWithFilters1");
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<20000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+ int rows = 4;
+ if (i % 12 == 5 || i % 17 == 3) {
+ rows = 2;
+ }
+ if (i % 15 == 4 || i % 7 == 4) {
+ rows = 6;
+ }
+
+ int q1 = Math.round(i/2);
+ int q2 = Math.round(i/2) + 1;
+ int q3 = Math.round(i/2) + 2;
+
+ if (i % 11 == 10 || i % 27 == 1) {
+ q1 = Math.round(q1/2);
+ q2 = Math.round(q2/2) + 1;
+ }
+
+ if(rows>4) {
+ p.addColumn(FAMILIES[0], toByteArray(""+ q3 + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q3 + rows), VALUES[0]);
+ }
+ if(rows>2) {
+ p.addColumn(FAMILIES[1], toByteArray(""+ q1 + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q2 + rows), VALUES[0]);
+ }
+ p.addColumn(FAMILIES[0], toByteArray(""+ q1 + rows), VALUES[0]);
+ p.addColumn(FAMILIES[0], toByteArray(""+ q2 +rows), VALUES[1]);
+
+ table.put(p);
+ }
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 20000 - 12355 + 10000 - 1235 + 1000 - 124 + 100 - 13 + 10 - 2;
+
+ byte[] start = toByteArray("12354");
+ byte[] stop = toByteArray("F");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+ limits.setMaxResultsPerColumnFamily(1);
+ Scan noLimits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+
+ int count1 = countScanRows(t, limits);
+ int count2 = countScanRows(t, noLimits);
+
+ assertEquals(expected, count2);
+ assertEquals(count1, count2);
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamilyBigger() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters2");
+ Admin admin = hbaseTestingUtility.getAdmin();
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<100000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+
+ int rows = 4;
+ if (i % 12 == 5 || i % 17 == 3) {
+ rows = 2;
+ }
+ if (i % 15 == 4 || i % 7 == 4) {
+ rows = 6;
+ }
+ if (i % 15 == 7 || i % 27 == 1) {
+ rows = 8;
+ }
+
+ int q1 = Math.round(i/2);
+ int q2 = Math.round(i/2) + 1;
+ int q3 = Math.round(i/2) + 2;
+ int q4 = Math.round(i/2) + 3;
+
+ if (i % 11 == 10 || i % 27 == 1) {
+ q1 = Math.round(q1/2);
+ q2 = Math.round(q2/2) + 1;
+ q3 = Math.round(q3/2) + 1;
+ q4 = Math.round(q4/2) + 1;
+ }
+
+ if(rows>6) {
+ p.addColumn(FAMILIES[0], toByteArray(""+ q4 + "-" + rows), VALUES[0]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q4 + "-" + rows), VALUES[1]);
+ }
+ if(rows>4) {
+ p.addColumn(FAMILIES[0], toByteArray(""+ q3 + "-" + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q3 + "-" + rows), VALUES[0]);
+ }
+ if(rows>2) {
+ p.addColumn(FAMILIES[1], toByteArray(""+ q1 + "-" + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q2 + "-" + rows), VALUES[0]);
+ }
+ p.addColumn(FAMILIES[0], toByteArray(""+ q2 + "-" + rows), VALUES[0]);
+ p.addColumn(FAMILIES[0], toByteArray(""+ q1 +"-" + rows), VALUES[1]);
+
+ table.put(p);
+ }
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 76531 - 12355 + 7653 - 1235 + 765 - 122 + 76 - 12 + 7 - 1;
+
+ byte[] start = toByteArray("12354");
+ byte[] stop = toByteArray("76531");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+ limits.setMaxResultsPerColumnFamily(1);
+ Scan noLimits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+
+ int count1 = countScanRows(t, limits);
+ int count2 = countScanRows(t, noLimits);
+
+ assertEquals(expected, count2);
+ assertEquals(count1, count2);
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamilySimpleBig() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters3");
+ Configuration conf = hbaseTestingUtility.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
+ Admin admin = hbaseTestingUtility.getAdmin();
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<100000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+ int q1 = 1;
+ int q2 = 2;
+
+ p.addColumn(FAMILIES[1], toByteArray(""+ q1), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q2), VALUES[0]);
+
+ p.addColumn(FAMILIES[0], toByteArray(""+ q2), VALUES[0]);
+ p.addColumn(FAMILIES[0], toByteArray(""+ q1), VALUES[1]);
+
+ table.put(p);
+ }
+
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 76531 - 12354 + 7653 - 1235 + 765 - 123 + 76 - 12 + 7 - 1;
+
+ byte[] start = toByteArray("12354");
+ byte[] stop = toByteArray("76531");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop).setReadType(Scan.ReadType.PREAD);
+ limits.setMaxResultsPerColumnFamily(1);
+
+ int count1 = countScanRows(t, limits);
+ assertEquals(expected, count1);
+ }
+
+ static int countScanRows(Table t, Scan scan) throws Exception {
+
+ int count = 0;
+ try(ResultScanner scanner = t.getScanner(scan)) {
+ for(Result r:scanner) {
+ count ++;
+ r.advance();
Review comment:
Thanks, I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r711108865
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamily() throws Exception {
+ Admin admin = hbaseTestingUtility.getAdmin();
+ TableName tableName = TableName.valueOf("TestScannersWithFilters1");
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<20000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+ int rows = 4;
+ if (i % 12 == 5 || i % 17 == 3) {
Review comment:
We don't need that.
I just wanted to create data where the number of columns are not the same for every row.
Thought it makes the data more realistic and it helped me to reproduce the issue in a test.
Note that testSetMaxResultsPerColumnFamilySimpleBig also reproduced the issue without that magic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r713897672
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void testSetMaxResultsPerColumnFamilySimple() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters3");
+ Configuration conf = hbaseTestingUtility.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
+ Admin admin = hbaseTestingUtility.getAdmin();
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+
+
+ for(int i = 0; i<30000; i++) {
+ byte [] ROW = Bytes.toBytes("" + i);
+ Put p = new Put(ROW);
+
+ p.addColumn(FAMILIES[0], Bytes.toBytes(""+ 1), VALUES[1]);
+ p.addColumn(FAMILIES[0], Bytes.toBytes(""+ 2), VALUES[0]);
+
+ table.put(p);
+ }
+
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 30000;
+
+ byte[] start = Bytes.toBytes("0");
+ byte[] stop = Bytes.toBytes("F");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop).setReadType(Scan.ReadType.PREAD);
Review comment:
Yes, I want to scan the whole table, i'll remove the start and stop row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] richardantal commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929117442
Thats good news. OK, let's use that approach.
Thanks @Apache9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929717994
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 50s | master passed |
| +1 :green_heart: | compile | 1m 2s | master passed |
| +1 :green_heart: | shadedjars | 8m 20s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 44s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 20s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 147m 12s | hbase-server in the patch passed. |
| | | 177m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 03b8cdf2d4f9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 113cc2a591 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/testReport/ |
| Max. process+thread count | 4592 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929256538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929114611
The pre commit result in #3701 seems alright. So let's use the new approach? OK by you @richardantal ?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r714566278
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -757,7 +757,7 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws
}
} while ((cell = this.heap.peek()) != null);
- if (count > 0) {
+ if (count > 0 || storeLimit > -1 && this.countPerRow > (storeLimit + storeOffset)) {
Review comment:
nit: it might look too many brackets but for better readability, good to add an additional bracket after first OR operator `if (a || (b && c))` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r711088282
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamily() throws Exception {
+ Admin admin = hbaseTestingUtility.getAdmin();
+ TableName tableName = TableName.valueOf("TestScannersWithFilters1");
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<20000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+ int rows = 4;
+ if (i % 12 == 5 || i % 17 == 3) {
+ rows = 2;
+ }
+ if (i % 15 == 4 || i % 7 == 4) {
+ rows = 6;
+ }
+
+ int q1 = Math.round(i/2);
+ int q2 = Math.round(i/2) + 1;
+ int q3 = Math.round(i/2) + 2;
+
+ if (i % 11 == 10 || i % 27 == 1) {
+ q1 = Math.round(q1/2);
+ q2 = Math.round(q2/2) + 1;
+ }
+
+ if(rows>4) {
+ p.addColumn(FAMILIES[0], toByteArray(""+ q3 + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q3 + rows), VALUES[0]);
+ }
+ if(rows>2) {
+ p.addColumn(FAMILIES[1], toByteArray(""+ q1 + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q2 + rows), VALUES[0]);
+ }
+ p.addColumn(FAMILIES[0], toByteArray(""+ q1 + rows), VALUES[0]);
+ p.addColumn(FAMILIES[0], toByteArray(""+ q2 +rows), VALUES[1]);
+
+ table.put(p);
+ }
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 20000 - 12355 + 10000 - 1235 + 1000 - 124 + 100 - 13 + 10 - 2;
+
+ byte[] start = toByteArray("12354");
+ byte[] stop = toByteArray("F");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+ limits.setMaxResultsPerColumnFamily(1);
+ Scan noLimits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+
+ int count1 = countScanRows(t, limits);
+ int count2 = countScanRows(t, noLimits);
+
+ assertEquals(expected, count2);
+ assertEquals(count1, count2);
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamilyBigger() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters2");
+ Admin admin = hbaseTestingUtility.getAdmin();
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<100000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+
+ int rows = 4;
+ if (i % 12 == 5 || i % 17 == 3) {
+ rows = 2;
+ }
+ if (i % 15 == 4 || i % 7 == 4) {
+ rows = 6;
+ }
+ if (i % 15 == 7 || i % 27 == 1) {
+ rows = 8;
+ }
+
+ int q1 = Math.round(i/2);
+ int q2 = Math.round(i/2) + 1;
+ int q3 = Math.round(i/2) + 2;
+ int q4 = Math.round(i/2) + 3;
+
+ if (i % 11 == 10 || i % 27 == 1) {
+ q1 = Math.round(q1/2);
+ q2 = Math.round(q2/2) + 1;
+ q3 = Math.round(q3/2) + 1;
+ q4 = Math.round(q4/2) + 1;
+ }
+
+ if(rows>6) {
+ p.addColumn(FAMILIES[0], toByteArray(""+ q4 + "-" + rows), VALUES[0]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q4 + "-" + rows), VALUES[1]);
+ }
+ if(rows>4) {
+ p.addColumn(FAMILIES[0], toByteArray(""+ q3 + "-" + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q3 + "-" + rows), VALUES[0]);
+ }
+ if(rows>2) {
+ p.addColumn(FAMILIES[1], toByteArray(""+ q1 + "-" + rows), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q2 + "-" + rows), VALUES[0]);
+ }
+ p.addColumn(FAMILIES[0], toByteArray(""+ q2 + "-" + rows), VALUES[0]);
+ p.addColumn(FAMILIES[0], toByteArray(""+ q1 +"-" + rows), VALUES[1]);
+
+ table.put(p);
+ }
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 76531 - 12355 + 7653 - 1235 + 765 - 122 + 76 - 12 + 7 - 1;
+
+ byte[] start = toByteArray("12354");
+ byte[] stop = toByteArray("76531");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+ limits.setMaxResultsPerColumnFamily(1);
+ Scan noLimits = new Scan().withStartRow(start).withStopRow(stop)
+ .setReadType(Scan.ReadType.PREAD);
+
+ int count1 = countScanRows(t, limits);
+ int count2 = countScanRows(t, noLimits);
+
+ assertEquals(expected, count2);
+ assertEquals(count1, count2);
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamilySimpleBig() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters3");
+ Configuration conf = hbaseTestingUtility.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
+ Admin admin = hbaseTestingUtility.getAdmin();
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<100000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+ int q1 = 1;
+ int q2 = 2;
+
+ p.addColumn(FAMILIES[1], toByteArray(""+ q1), VALUES[1]);
+ p.addColumn(FAMILIES[1], toByteArray(""+ q2), VALUES[0]);
+
+ p.addColumn(FAMILIES[0], toByteArray(""+ q2), VALUES[0]);
+ p.addColumn(FAMILIES[0], toByteArray(""+ q1), VALUES[1]);
+
+ table.put(p);
+ }
+
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 76531 - 12354 + 7653 - 1235 + 765 - 123 + 76 - 12 + 7 - 1;
+
+ byte[] start = toByteArray("12354");
+ byte[] stop = toByteArray("76531");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop).setReadType(Scan.ReadType.PREAD);
+ limits.setMaxResultsPerColumnFamily(1);
+
+ int count1 = countScanRows(t, limits);
+ assertEquals(expected, count1);
+ }
+
+ static int countScanRows(Table t, Scan scan) throws Exception {
+
+ int count = 0;
+ try(ResultScanner scanner = t.getScanner(scan)) {
+ for(Result r:scanner) {
+ count ++;
+ r.advance();
Review comment:
Why call advance here?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamily() throws Exception {
+ Admin admin = hbaseTestingUtility.getAdmin();
+ TableName tableName = TableName.valueOf("TestScannersWithFilters1");
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ ColumnFamilyDescriptorBuilder cfBuilder1 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build())
+ .setColumnFamily(cfBuilder1.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+ for(int i = 0; i<20000; i++) {
+ byte [] ROW = toByteArray("" + i);
+ Put p = new Put(ROW);
+ p.setDurability(Durability.SKIP_WAL);
+
+ int rows = 4;
+ if (i % 12 == 5 || i % 17 == 3) {
Review comment:
Do we really need these magics to reproduce the bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-921809637
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 0s | master passed |
| +1 :green_heart: | compile | 0m 59s | master passed |
| +1 :green_heart: | shadedjars | 8m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 40s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 18s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 148m 37s | hbase-server in the patch passed. |
| | | 178m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 9d11f8dfc805 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c60adfd13a |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/testReport/ |
| Max. process+thread count | 5137 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925482529
Please give me sometime to verify the patch.
Sorry for the delay...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929665036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi merged pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
petersomogyi merged pull request #3688:
URL: https://github.com/apache/hbase/pull/3688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929756493
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 36s | master passed |
| +1 :green_heart: | compile | 1m 31s | master passed |
| +1 :green_heart: | shadedjars | 9m 50s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 20s | the patch passed |
| +1 :green_heart: | compile | 1m 32s | the patch passed |
| +1 :green_heart: | javac | 1m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 52s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 231m 4s | hbase-server in the patch passed. |
| | | 269m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b5e9fe3e6dd3 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 113cc2a591 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/testReport/ |
| Max. process+thread count | 2911 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/8/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-922027408
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 19s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 29s | master passed |
| +1 :green_heart: | compile | 1m 35s | master passed |
| +1 :green_heart: | shadedjars | 10m 42s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 54s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 37s | the patch passed |
| +1 :green_heart: | javac | 1m 37s | the patch passed |
| +1 :green_heart: | shadedjars | 10m 33s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 248m 14s | hbase-server in the patch failed. |
| | | 290m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux e08661982e10 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4614c7bc57 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/testReport/ |
| Max. process+thread count | 2834 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r717696072
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -757,7 +757,7 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws
}
} while ((cell = this.heap.peek()) != null);
- if (count > 0) {
+ if (count > 0 || (storeLimit > -1 && this.countPerRow > (storeLimit + storeOffset))) {
Review comment:
We do not need to add this extra check any more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929380528
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 47s | master passed |
| +1 :green_heart: | compile | 1m 3s | master passed |
| +1 :green_heart: | shadedjars | 8m 14s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 16s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 159m 34s | hbase-server in the patch failed. |
| | | 189m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 5f4e39aed0ad 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / cbebf85b3c |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/testReport/ |
| Max. process+thread count | 4635 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925099775
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 33s | master passed |
| +1 :green_heart: | compile | 1m 16s | master passed |
| +1 :green_heart: | shadedjars | 8m 45s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 34s | the patch passed |
| +1 :green_heart: | compile | 1m 16s | the patch passed |
| +1 :green_heart: | javac | 1m 16s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 58s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 146m 18s | hbase-server in the patch failed. |
| | | 179m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c3b1491b40e6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96fa015043 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/testReport/ |
| Max. process+thread count | 4075 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-921884576
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 31s | master passed |
| +1 :green_heart: | compile | 3m 35s | master passed |
| +1 :green_heart: | checkstyle | 1m 13s | master passed |
| +1 :green_heart: | spotbugs | 2m 24s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 10s | the patch passed |
| +1 :green_heart: | compile | 3m 28s | the patch passed |
| +1 :green_heart: | javac | 3m 28s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 9s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 20m 38s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 24s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 53m 22s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 34d9b2e542da 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4614c7bc57 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-925337301
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 36s | master passed |
| +1 :green_heart: | compile | 1m 32s | master passed |
| +1 :green_heart: | shadedjars | 9m 51s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 50s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 23s | the patch passed |
| +1 :green_heart: | compile | 1m 30s | the patch passed |
| +1 :green_heart: | javac | 1m 30s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 48s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 233m 42s | hbase-server in the patch passed. |
| | | 271m 50s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 27a043a9e755 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d956828aac |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/testReport/ |
| Max. process+thread count | 2993 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
petersomogyi commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r710968681
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void tesSetMaxResultsPerColumnFamily() throws Exception {
Review comment:
s/tesSetMaxResultsPerColumnFamily/testSetMaxResultsPerColumnFamily
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void testSetMaxResultsPerColumnFamilySimple() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters3");
Review comment:
You can use a `@Rule` annotation to get the table name based on the test's name:
https://github.com/apache/hbase/blob/master/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java#L56-L57
https://github.com/apache/hbase/blob/master/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java#L111
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void testSetMaxResultsPerColumnFamilySimple() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters3");
+ Configuration conf = hbaseTestingUtility.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
+ Admin admin = hbaseTestingUtility.getAdmin();
+ if (!admin.tableExists(tableName)) {
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = hbaseTestingUtility.getConnection().getTable(tableName);
+
+
+
+ for(int i = 0; i<30000; i++) {
+ byte [] ROW = Bytes.toBytes("" + i);
+ Put p = new Put(ROW);
+
+ p.addColumn(FAMILIES[0], Bytes.toBytes(""+ 1), VALUES[1]);
+ p.addColumn(FAMILIES[0], Bytes.toBytes(""+ 2), VALUES[0]);
+
+ table.put(p);
+ }
+
+ table.close();
+ }
+
+ Table t = hbaseTestingUtility.getConnection().getTable(tableName);
+ int expected = 30000;
+
+ byte[] start = Bytes.toBytes("0");
+ byte[] stop = Bytes.toBytes("F");
+
+ Scan limits = new Scan().withStartRow(start).withStopRow(stop).setReadType(Scan.ReadType.PREAD);
Review comment:
You're ingesting rowkeys from `0` to `30000` (in practice 0-9999) so this limit will not reduce the returned rows. Is that intentional?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
Review comment:
This can be inlined, no need to have a static method to call Bytes.toBytes.
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ public static byte[] toByteArray(String s) {
+ return Bytes.toBytes(s);
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
Review comment:
Do you need 3 RegionServers for this test?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ hbaseTestingUtility.startMiniCluster(3);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ hbaseTestingUtility.shutdownMiniCluster();
+ }
+
+ @Test
+ public void testSetMaxResultsPerColumnFamilySimple() throws Exception {
+ TableName tableName = TableName.valueOf("TestScannersWithFilters3");
+ Configuration conf = hbaseTestingUtility.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
+ Admin admin = hbaseTestingUtility.getAdmin();
+ if (!admin.tableExists(tableName)) {
Review comment:
Probably there is no need to check the table's existence.
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil();
Review comment:
Rename the variable to `UTIL`.
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RestTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({RestTests.class, MediumTests.class})
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(
Review comment:
This logger is not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-921968391
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 36s | master passed |
| +1 :green_heart: | compile | 1m 4s | master passed |
| +1 :green_heart: | shadedjars | 9m 32s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 3s | the patch passed |
| +1 :green_heart: | compile | 1m 9s | the patch passed |
| +1 :green_heart: | javac | 1m 9s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 33s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 153m 17s | hbase-server in the patch passed. |
| | | 187m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 14fde4c3ec66 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4614c7bc57 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/testReport/ |
| Max. process+thread count | 4651 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r714731179
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,121 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+
+@Category(MediumTests.class)
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil UTIL = new HBaseTestingUtil();
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ UTIL.shutdownMiniCluster();
+ }
+
+ @Rule
+ public TestName name = new TestName();
+
+ @Test
+ public void testSetMaxResultsPerColumnFamilySimple() throws Exception {
+ TableName tableName = TableName.valueOf(name.getMethodName());
+ Configuration conf = UTIL.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
+ Admin admin = UTIL.getAdmin();
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = UTIL.getConnection().getTable(tableName);
+
+ for(int i = 0; i<30000; i++) {
+ byte [] ROW = Bytes.toBytes("" + i);
+ Put p = new Put(ROW);
+
+ p.addColumn(FAMILIES[0], Bytes.toBytes(""+ 1), VALUES[1]);
+ p.addColumn(FAMILIES[0], Bytes.toBytes(""+ 2), VALUES[0]);
+
+ table.put(p);
+ }
+
+ table.close();
+
+ Table t = UTIL.getConnection().getTable(tableName);
Review comment:
same here
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,121 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+
+@Category(MediumTests.class)
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil UTIL = new HBaseTestingUtil();
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ UTIL.shutdownMiniCluster();
+ }
+
+ @Rule
+ public TestName name = new TestName();
+
+ @Test
+ public void testSetMaxResultsPerColumnFamilySimple() throws Exception {
+ TableName tableName = TableName.valueOf(name.getMethodName());
+ Configuration conf = UTIL.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
Review comment:
Is this required?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java
##########
@@ -0,0 +1,121 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+
+@Category(MediumTests.class)
+public class TestMaxResultsPerColumnFamily {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class);
+
+ private static final byte [][] FAMILIES = {
+ Bytes.toBytes("1"), Bytes.toBytes("2")
+ };
+
+ private static final byte [][] VALUES = {
+ Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo")
+ };
+
+ private static final HBaseTestingUtil UTIL = new HBaseTestingUtil();
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+ UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ UTIL.shutdownMiniCluster();
+ }
+
+ @Rule
+ public TestName name = new TestName();
+
+ @Test
+ public void testSetMaxResultsPerColumnFamilySimple() throws Exception {
+ TableName tableName = TableName.valueOf(name.getMethodName());
+ Configuration conf = UTIL.getConfiguration();
+ conf.setInt(HConstants.MAJOR_COMPACTION_PERIOD, 0);
+ Admin admin = UTIL.getAdmin();
+ ColumnFamilyDescriptorBuilder cfBuilder0 =
+ ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+
+ TableDescriptor tableDescriptor =
+ TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build()).build();
+ admin.createTable(tableDescriptor);
+ Table table = UTIL.getConnection().getTable(tableName);
Review comment:
nit: use try-with-resource?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3688: HBASE-26289 Hbase scan setMaxResultsPerColumnFamily not giving right …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#issuecomment-929418367
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 2s | master passed |
| +1 :green_heart: | compile | 1m 18s | master passed |
| +1 :green_heart: | shadedjars | 9m 14s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 44s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 50s | the patch passed |
| +1 :green_heart: | compile | 1m 20s | the patch passed |
| +1 :green_heart: | javac | 1m 20s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 2s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 205m 42s | hbase-server in the patch passed. |
| | | 240m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3688 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 41fe2a494a76 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / cbebf85b3c |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/testReport/ |
| Max. process+thread count | 3697 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3688/7/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org