[GitHub] rhtyd commented on a change in pull request #2706: packaging: use libuuid x86_64 package for cloudstack-common

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2706: packaging: use libuuid x86_64 package for cloudstack-common
URL: https://github.com/apache/cloudstack/pull/2706#discussion_r195366395
 
 

 ##########
 File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
 ##########
 @@ -78,12 +78,7 @@ function install_packages() {
   apt-get clean
   apt-get autoclean
 
-  #32 bit architecture support:: not required for 32 bit template
-  if [ "${arch}" != "i386" ]; then
-    dpkg --add-architecture i386
-    apt-get update
-    ${apt_get} install links:i386 libuuid1:i386 libc6:i386
-  fi
+  ${apt_get} install links
 
 Review comment:
   The vhd-util we bundle with systemvm.iso/cloudstack is used by ssvm, and needs the i386 libs:
   ldd ./scripts/vm/hypervisor/xenserver/vhd-util
   	linux-gate.so.1 =>  (0xf7f23000)
   	libuuid.so.1 => /lib/i386-linux-gnu/libuuid.so.1 (0xf7edb000)
   	libc.so.6 => /lib/i386-linux-gnu/libc.so.6 (0xf7d05000)
   	/lib/ld-linux.so.2 (0xf7f25000)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services