You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "greyp9 (via GitHub)" <gi...@apache.org> on 2024/07/23 19:03:18 UTC
[PR] NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806) [nifi]
greyp9 opened a new pull request, #9106:
URL: https://github.com/apache/nifi/pull/9106
https://github.com/greyp9/nifi/actions/runs/10063850436
# Summary
[NIFI-13553](https://issues.apache.org/jira/browse/NIFI-13553)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806) [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #9106:
URL: https://github.com/apache/nifi/pull/9106#discussion_r1698676873
##########
nifi-extension-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -29,7 +29,9 @@
<properties>
<!-- when changing the Azure SDK version, also update msal4j to the version that is required by azure-identity -->
<azure.sdk.bom.version>1.2.25</azure.sdk.bom.version>
- <msal4j.version>1.15.1</msal4j.version>
+ <!-- msal4j:1.16.x compatible with msal4j:1.14, msal4j:1.15 APIs -->
+ <!-- https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/828 -->
Review Comment:
https://github.com/apache/nifi/pull/9104
This PR covers the same version in 1.x. Would you mind having a look there as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806) [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9106:
URL: https://github.com/apache/nifi/pull/9106#discussion_r1698713868
##########
nifi-extension-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -29,7 +29,9 @@
<properties>
<!-- when changing the Azure SDK version, also update msal4j to the version that is required by azure-identity -->
<azure.sdk.bom.version>1.2.25</azure.sdk.bom.version>
- <msal4j.version>1.15.1</msal4j.version>
+ <!-- msal4j:1.16.x compatible with msal4j:1.14, msal4j:1.15 APIs -->
+ <!-- https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/828 -->
Review Comment:
Thanks @greyp9, I will remove the comments and merge this version update to the main branch. I recommend doing the same on the other PR, feel free to proceed with one if it otherwise looks good to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806) [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #9106:
URL: https://github.com/apache/nifi/pull/9106#discussion_r1698678580
##########
nifi-extension-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -29,7 +29,9 @@
<properties>
<!-- when changing the Azure SDK version, also update msal4j to the version that is required by azure-identity -->
<azure.sdk.bom.version>1.2.25</azure.sdk.bom.version>
- <msal4j.version>1.15.1</msal4j.version>
+ <!-- msal4j:1.16.x compatible with msal4j:1.14, msal4j:1.15 APIs -->
+ <!-- https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/828 -->
Review Comment:
... same guidance on the comment. I think that contributor was following my lead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806) [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9106:
URL: https://github.com/apache/nifi/pull/9106#discussion_r1696945795
##########
nifi-extension-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -29,7 +29,9 @@
<properties>
<!-- when changing the Azure SDK version, also update msal4j to the version that is required by azure-identity -->
<azure.sdk.bom.version>1.2.25</azure.sdk.bom.version>
- <msal4j.version>1.15.1</msal4j.version>
+ <!-- msal4j:1.16.x compatible with msal4j:1.14, msal4j:1.15 APIs -->
+ <!-- https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/828 -->
Review Comment:
Although these comments are helpful now, they could quickly become outdated on subsequent updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806) [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #9106:
URL: https://github.com/apache/nifi/pull/9106#discussion_r1698570437
##########
nifi-extension-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -29,7 +29,9 @@
<properties>
<!-- when changing the Azure SDK version, also update msal4j to the version that is required by azure-identity -->
<azure.sdk.bom.version>1.2.25</azure.sdk.bom.version>
- <msal4j.version>1.15.1</msal4j.version>
+ <!-- msal4j:1.16.x compatible with msal4j:1.14, msal4j:1.15 APIs -->
+ <!-- https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/828 -->
Review Comment:
Sure, please remove the comment if you think it is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806) [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #9106: NIFI-13553 - update msal4j (AzureAD/msal4j/issues/806)
URL: https://github.com/apache/nifi/pull/9106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org