You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/23 19:12:53 UTC

[GitHub] [helix] zhangmeng916 opened a new pull request #963: Add Customized State View Aggregation Feature

zhangmeng916 opened a new pull request #963:
URL: https://github.com/apache/helix/pull/963


   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the PR description:
   
   (#728 )
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR implements Helix customized state view aggregation feature. This feature allow Helix users to have their own defined states for each partition, provide them APIs to update the states when there's any change, and also help them aggregate the customized states into a customized view similar to existing external view. Finally, users could get the aggregated view from routing table provider. 
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   
   - [X] The following is the result of the "mvn test" command on the appropriate module:
   TestCustomizedStateUpdate
   TestCustomizedStateComputationStage
   TestCustomizedViewStage
   TestComputeAndCleanupCustomizedView
   TestCustomizedViewAggregation
   
   [WARNING] Tests run: 1144, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 4,645.631 s - in TestSuite
   [INFO] 
   [INFO] Results:
   [INFO] 
   [WARNING] Tests run: 1144, Failures: 0, Errors: 0, Skipped: 1
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  01:17 h
   [INFO] Finished at: 2020-04-23T12:02:40-07:00
   
   helix-rest: (known issues, will be fixed in the following PRs)
   
   [ERROR] Failures: 
   [ERROR]   TestZkRoutingDataReader.testGetRoutingData:81 » ZkMarshalling java.io.NotSeria...
   [ERROR]   TestZkRoutingDataWriter.testAddMetadataStoreRealm:87 » ZkMarshalling java.io.S...
   [INFO] 
   [ERROR] Tests run: 159, Failures: 2, Errors: 0, Skipped: 11
   [INFO] 
   
   ### Commits
   
   - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [X] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org