You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/27 13:59:23 UTC
[GitHub] [netbeans] akronenw opened a new pull request, #4694: Fixed JBoss EAP regex patterns to match two digit minor/patch versions
akronenw opened a new pull request, #4694:
URL: https://github.com/apache/netbeans/pull/4694
This PR fixes a flaw in the Wildfly server log line parsing regexes.
In the old version, JBoss EAP 6 (and 7) servers with two digit patch version (e.g. 6.4.23) are not detected, same for minor version.
In EAP 7 it is possible that there is an additional whitespace between the time it took to start the server and the time unit (e.g. 4700 ms instead of 4700ms).
That issue is also fixed.
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4694: Fixed JBoss EAP regex patterns to match two digit minor/patch versions
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4694:
URL: https://github.com/apache/netbeans/pull/4694#issuecomment-1263891156
@akronenw the question @ebarboni raises is: Did you read the license statement at the head of the files you modified/created and are you aware, that you donate the change to the ASF and thus allow the ASF to relicense them if necessary at a later time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4694: Fixed JBoss EAP regex patterns to match two digit minor/patch versions
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4694:
URL: https://github.com/apache/netbeans/pull/4694#issuecomment-1263529793
Hi, as you are first time contributor you should take a look at https://github.com/apache/netbeans/blob/master/.github/PULL_REQUEST_TEMPLATE.md and make it explicit in the comment I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4694: Fixed JBoss EAP regex patterns to match two digit minor/patch versions
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4694:
URL: https://github.com/apache/netbeans/pull/4694#issuecomment-1264559549
@akronenw The text can be easily overlooked, we simply checked if you have read it since you are a first time contributor.
```
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes
are all your own work, and you have the right to contribute them.
are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
```
do you agree with this? yes/no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] akronenw commented on pull request #4694: Fixed JBoss EAP regex patterns to match two digit minor/patch versions
Posted by GitBox <gi...@apache.org>.
akronenw commented on PR #4694:
URL: https://github.com/apache/netbeans/pull/4694#issuecomment-1264563850
Yes, I agree.
Michael Bien ***@***.***> schrieb am So., 2. Okt. 2022, 07:55:
> @akronenw <https://github.com/akronenw> The text can be easily
> overlooked, we simply checked if you have read it since you are a first
> time contributor.
>
> By opening a pull request you confirm that, unless explicitly stated otherwise, the changes
>
> are all your own work, and you have the right to contribute them.
> are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
>
> do you agree with this? yes/no?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/netbeans/pull/4694#issuecomment-1264559549>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFNCUH5MCQ33FBARADDIXKLWBEPURANCNFSM6AAAAAAQW2ETOY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] akronenw commented on pull request #4694: Fixed JBoss EAP regex patterns to match two digit minor/patch versions
Posted by GitBox <gi...@apache.org>.
akronenw commented on PR #4694:
URL: https://github.com/apache/netbeans/pull/4694#issuecomment-1264323948
Hello @ebarboni, I didn't get your point at first.
Thanks @matthiasblaesing for clarifying.
I did read the linked PR template and the guide to contributing code before creating the PR. As I don't understand it that way, was I supposed to state in the PR comment that I read those guides?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists