You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2019/07/29 10:54:54 UTC
[GitHub] [incubator-weex] YorkShen commented on a change in pull request
#2738: [Android]fix setViewPort invalid
YorkShen commented on a change in pull request #2738: [Android]fix setViewPort invalid
URL: https://github.com/apache/incubator-weex/pull/2738#discussion_r308169075
##########
File path: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
##########
@@ -454,6 +454,7 @@ public void setUseScroller(boolean use) {
public void setInstanceViewPortWidth(int instanceViewPortWidth) {
this.mInstanceViewPortWidth = instanceViewPortWidth;
this.mAutoAdjustDeviceWidth = false;
+ WXBridgeManager.getInstance().setViewPortWidth(getInstanceId(),mInstanceViewPortWidth);
Review comment:
There is no need to call c++ code if this `setInstanceViewPortWidth` is invoked by WXMetaModule.setViewport
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services