Re: [PR] [#1579] fix(spark): Adjust reassigned time to ensure that all previous data is cleared for stage retry [incubator-uniffle]

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on code in PR #1584:
URL: https://github.com/apache/incubator-uniffle/pull/1584#discussion_r1538538570


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -158,6 +158,30 @@ public void registerShuffle(
     String remoteStoragePath = req.getRemoteStorage().getPath();
     String user = req.getUser();
 
+    if (req.getIsStageRetry()) {

Review Comment:
   I prefer reserving the `isStageRetry`(or use stage attempt number to replace this) param for 2 reasons
   
   1. this is more explicit for stage retry, especially when something go wrong, like the previous data has been purged due to expire heartbeat. If having this, the log will indicate the abnormal problem happens
   2. for the next PR, I will introduce the stage latest attempt to discard the older attempt data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org