Re: [PR] [AMORO-3632]: data-retention, add support for partition column type Date [amoro]

["zhoujinsong (via GitHub)" <gi...@apache.org>]

zhoujinsong commented on code in PR #3665:
URL: https://github.com/apache/amoro/pull/3665#discussion_r2253008077


##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/maintainer/IcebergTableMaintainer.java:
##########
@@ -743,6 +743,17 @@ protected ExpireFiles expiredFileScan(
     return expiredFiles;
   }
 
+  /**
+   * Convert expiration timestamp to appropriate value based on field type. This method handles

Review Comment:
   I tried to format the comment here to make it more readable:
   ```
     /**
      * Convert expiration timestamp to the appropriate value based on field type.
      *
      * <p>This method handles different field types for data expiration:
      *
      * <ul>
      *   <li>TIMESTAMP: converts milliseconds to microseconds
      *   <li>LONG: handles both millisecond and second formats
      *   <li>STRING: formats timestamp as date string using configured pattern
      *   <li>DATE: converts timestamp to days since epoch
      * </ul>
      *
      * @param expirationConfig expiration configuration containing format patterns
      * @param field the field being used for expiration
      * @param expireTimestamp timestamp in milliseconds for expiration boundary
      * @return comparable value appropriate for the field type
      */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org