You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2025/07/28 13:02:41 UTC

[PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

JiriOndrusek opened a new pull request, #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50

   We need to keep some classes public even if it is against [OpenRewrite best practices](https://github.com/apache/camel-upgrade-recipes/pull/45#issuecomment-3117984564).
   
   I added comments to all those places, to avoid any future reverts.
   
   FYI @timtebeek 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#discussion_r2236371315


##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate410Test.java:
##########
@@ -26,7 +26,8 @@
 import static org.openrewrite.properties.Assertions.properties;
 import static org.openrewrite.xml.Assertions.xml;
 
-class CamelUpdate410Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate410Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate410Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate413Test.java:
##########
@@ -27,7 +27,8 @@
 import static org.openrewrite.xml.Assertions.xml;
 import static org.openrewrite.yaml.Assertions.yaml;
 
-class CamelUpdate413Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate413Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate413Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate49Test.java:
##########
@@ -25,7 +25,8 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.maven.Assertions.pomXml;
 
-class CamelUpdate49Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate49Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate49Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CameXmlDslRecipeTest.java:
##########
@@ -26,7 +26,8 @@
 
 import static org.openrewrite.xml.Assertions.xml;
 
-class CameXmlDslRecipeTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CameXmlDslRecipeTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CameXmlDslRecipeTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel44/CamelUpdate41Test.java:
##########
@@ -27,7 +27,8 @@
 import static org.openrewrite.xml.Assertions.xml;
 import static org.openrewrite.yaml.Assertions.yaml;
 
-class CamelUpdate41Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate41Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate41Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CamelYamlTest.java:
##########
@@ -25,7 +25,8 @@
 
 import static org.openrewrite.yaml.Assertions.yaml;
 
-class CamelYamlTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelYamlTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelYamlTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate411Test.java:
##########
@@ -26,7 +26,8 @@
 import static org.openrewrite.maven.Assertions.pomXml;
 import static org.openrewrite.properties.Assertions.properties;
 
-class CamelUpdate411Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate411Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate411Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate412Test.java:
##########
@@ -29,7 +29,8 @@
 import static org.openrewrite.xml.Assertions.xml;
 import static org.openrewrite.yaml.Assertions.yaml;
 
-class CamelUpdate412Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate412Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate412Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CamelAPIsPropertiesTest.java:
##########
@@ -26,7 +26,8 @@
 
 import static org.openrewrite.properties.Assertions.properties;
 
-class CamelAPIsPropertiesTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelAPIsPropertiesTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelAPIsPropertiesTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate46Test.java:
##########
@@ -27,7 +27,8 @@
 import static org.openrewrite.xml.Assertions.xml;
 import static org.openrewrite.yaml.Assertions.yaml;
 
-class CamelUpdate46Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate46Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate46Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CamelJmxTest.java:
##########
@@ -25,7 +25,8 @@
 
 import static org.openrewrite.java.Assertions.java;
 
-class CamelJmxTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelJmxTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelJmxTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CamelEIPRecipeTest.java:
##########
@@ -25,7 +25,8 @@
 
 import static org.openrewrite.java.Assertions.java;
 
-class CamelEIPRecipeTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelEIPRecipeTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelEIPRecipeTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate45Test.java:
##########
@@ -25,7 +25,8 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.properties.Assertions.properties;
 
-class CamelUpdate45Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate45Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate45Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate47Test.java:
##########
@@ -27,7 +27,8 @@
 import static org.openrewrite.xml.Assertions.xml;
 import static org.openrewrite.yaml.Assertions.yaml;
 
-class CamelUpdate47Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate47Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate47Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CamelBeanRecipeTest.java:
##########
@@ -25,7 +25,8 @@
 
 import static org.openrewrite.java.Assertions.java;
 
-class CamelBeanRecipeTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelBeanRecipeTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelBeanRecipeTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CamelHttpTest.java:
##########
@@ -25,7 +25,8 @@
 
 import static org.openrewrite.java.Assertions.java;
 
-class CamelHttpTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelHttpTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelHttpTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel44/CamelUpdate44Test.java:
##########
@@ -27,7 +27,8 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.properties.Assertions.properties;
 
-class CamelUpdate44Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate44Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate44Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel40/CamelAPIsTest.java:
##########
@@ -25,7 +25,8 @@
 
 import static org.openrewrite.java.Assertions.java;
 
-class CamelAPIsTest implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelAPIsTest implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelAPIsTest implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel44/CamelUpdate43Test.java:
##########
@@ -26,7 +26,8 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.xml.Assertions.xml;
 
-class CamelUpdate43Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate43Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate43Test implements RewriteTest {
   ```



##########
camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/camel44/CamelUpdate42Test.java:
##########
@@ -26,7 +26,8 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.properties.Assertions.properties;
 
-class CamelUpdate42Test implements RewriteTest {
+//class has to stay public, because test is extended in project quarkus-updates
+public class CamelUpdate42Test implements RewriteTest {

Review Comment:
   ```suggestion
   class CamelUpdate42Test implements RewriteTest {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127467855

   Thanks yes happy to help as well, whether that's by providing a PR or review; just let me know and I'll try to fit it in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127248480

   Adding 
   ```
   <exclusions>
       <exclusion>*/src/test/java/**</exclusion>
   </exclusions>
   ```
   works as expected, by looking at docs it seems like this is the only option to exclude java classes in this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127161589

   oh yeah, @JiriOndrusek @timtebeek as you can see from all the comments, the CI is working as expected :), @timtebeek is it possible to add exlusions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127368406

   > Thanks all ; unexpected that the tests would be reused indeed; the current workaround works, but would stop all recipes from applying to those files.
   > 
   > If you'd want to be more selective as to which recipes are run, then we have such an example here as well, by adding a `rewrite.yml` with just a [subset of recipes from this larger list](https://github.com/openrewrite/rewrite-rewrite/blob/2d0d6ec4a0fc745556c2b90801ca73f09429d91f/src/main/resources/META-INF/rewrite/recipebestpractice.yml#L18-L111) https://github.com/openrewrite/rewrite-maven-plugin/blob/b9e83adde9893d910e08606b5e098facda0f977e/rewrite.yml#L19-L28
   > 
   > You'll want to update the reference here, but other than that we've found that pattern to work quite well:
   > 
   > https://github.com/apache/camel-upgrade-recipes/blob/b66c1d2f516680678e81a471135db9f20c92c879/pom.xml#L179
   > 
   > Let me know if you'd want help to find and adopt those patterns to only exclude the recipe that makes the test non-private.
   
   Thanks!
   yeah, a custom recipe sounds good, but we'll have to maintain it our own, right? 
   
   @JiriOndrusek fyi, this is what we discussed as well, I think it is better compared to full `src/test` exclusion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127172467

   Although the build was successfull, I see in logs:
   
   ````
   [ERROR] Recipe validation error in initialization: DeclarativeRecipe must not contain uninitialized recipes. Be sure to call .initialize() on DeclarativeRecipe.
   [ERROR] Recipe validation error in org.openrewrite.java.recipes.RecipeNullabilityBestPractices.recipeList[4] (in jar:file:///home/jondruse/.m2/repository/org/openrewrite/recipe/rewrite-rewrite/0.10.1/rewrite-rewrite-0.10.1.jar!/META-INF/rewrite/recipebestpractice.yml): recipe 'org.openrewrite.java.jspecify.MigrateToJspecify' does not exist.
   [ERROR] Recipe validation error in org.openrewrite.java.recipes.RecipeNullabilityBestPractices.recipeList[4] (in jar:file:///home/jondruse/.m2/repository/org/openrewrite/recipe/rewrite-rewrite/0.10.1/rewrite-rewrite-0.10.1.jar!/META-INF/rewrite/recipebestpractice.yml): recipe 'org.openrewrite.java.jspecify.MigrateToJspecify' does not exist.
   [ERROR] Recipe validation error in initialization: DeclarativeRecipe must not contain uninitialized recipes. Be sure to call .initialize() on DeclarativeRecipe.
   [ERROR] Recipe validation error in org.openrewrite.java.recipes.RecipeNullabilityBestPractices.recipeList[4] (in jar:file:///home/jondruse/.m2/repository/org/openrewrite/recipe/rewrite-rewrite/0.10.1/rewrite-rewrite-0.10.1.jar!/META-INF/rewrite/recipebestpractice.yml): recipe 'org.openrewrite.java.jspecify.MigrateToJspecify' does not exist.
   [ERROR] Recipe validation error in org.openrewrite.java.recipes.RecipeNullabilityBestPractices.recipeList[4] (in jar:file:///home/jondruse/.m2/repository/org/openrewrite/recipe/rewrite-rewrite/0.10.1/rewrite-rewrite-0.10.1.jar!/META-INF/rewrite/recipebestpractice.yml): recipe 'org.openrewrite.java.jspecify.MigrateToJspecify' does not exist.
   [ERROR] Recipe validation errors detected as part of one or more activeRecipe(s). Execution will continue regardless.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127168967

   > mvn -Popenrewrite rewrite:run
   
   I checked that and the result was successfull.
   
   Is there any difference in coverage of `mvn -Popenrewrite rewrite:run` and `mvn clean test`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek merged PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127356086

   Thanks all ; unexpected that the tests would be reused indeed; the current workaround works, but would stop all recipes from applying to those files.
   
   If you'd want to be more selective as to which recipes are run, then we have such an example here as well, by adding a `rewrite.yml` with just a [subset of recipes from this larger list](https://github.com/openrewrite/rewrite-rewrite/blob/2d0d6ec4a0fc745556c2b90801ca73f09429d91f/src/main/resources/META-INF/rewrite/recipebestpractice.yml#L18-L111)
   https://github.com/openrewrite/rewrite-maven-plugin/blob/b9e83adde9893d910e08606b5e098facda0f977e/rewrite.yml#L19-L28
   
   You'll want to update the reference here, but other than that we've found that pattern to work quite well:
   https://github.com/apache/camel-upgrade-recipes/blob/b66c1d2f516680678e81a471135db9f20c92c879/pom.xml#L179
   
   Let me know if you'd want help to find and adopt those patterns to only exclude the recipe that makes the test non-private.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127158894

   @JiriOndrusek did you try `mvn -Popenrewrite rewrite:run` locally? was the build successful?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127264654

   I added exclusion for the test classes, thanks @Croway  for the hint
   
   ```
   <exclusions>
         <exclusion>*/src/test/java/**</exclusion>
     </exclusions>
   ```                            


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make tests extendable for quarkus-updates [camel-upgrade-recipes]

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #50:
URL: https://github.com/apache/camel-upgrade-recipes/pull/50#issuecomment-3127388008

   > Thanks all ; unexpected that the tests would be reused indeed; the current workaround works, but would stop all recipes from applying to those files.
   > 
   > If you'd want to be more selective as to which recipes are run, then we have such an example here as well, by adding a `rewrite.yml` with just a [subset of recipes from this larger list](https://github.com/openrewrite/rewrite-rewrite/blob/2d0d6ec4a0fc745556c2b90801ca73f09429d91f/src/main/resources/META-INF/rewrite/recipebestpractice.yml#L18-L111) https://github.com/openrewrite/rewrite-maven-plugin/blob/b9e83adde9893d910e08606b5e098facda0f977e/rewrite.yml#L19-L28
   > 
   > You'll want to update the reference here, but other than that we've found that pattern to work quite well:
   > 
   > https://github.com/apache/camel-upgrade-recipes/blob/b66c1d2f516680678e81a471135db9f20c92c879/pom.xml#L179
   > 
   > Let me know if you'd want help to find and adopt those patterns to only exclude the recipe that makes the test non-private.
   
   Hi @timtebeek thanks for the suggestion. I was thinking about a custom recipe, containing only a subset of the bestprectice recipes. I'll check you links in the near future and will try to prepare a better solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org