[GitHub] [superset] john-bodley commented on a change in pull request #11970: feat: add hook for dataset health check

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #11970:
URL: https://github.com/apache/superset/pull/11970#discussion_r608092629



##########
File path: superset/views/core.py
##########
@@ -650,6 +650,10 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 f"datasource_id={datasource_id}&"
             )
 
+        # if feature enabled, run some health check rules for sqla datasource
+        if hasattr(datasource, "health_check"):
+            datasource.health_check()

Review comment:
       @graceguo-supercat why in this instance do we not require to force a check, i.e., `datasource.health_check(force=True)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org