[GitHub] [nuttx-apps] Gary-Hobson commented on a diff in pull request #1640: nshlib: one-time output uname

["Gary-Hobson (via GitHub)" <gi...@apache.org>]

Gary-Hobson commented on code in PR #1640:
URL: https://github.com/apache/nuttx-apps/pull/1640#discussion_r1129301871


##########
nshlib/nsh_syscmds.c:
##########
@@ -579,6 +581,8 @@ int cmd_uname(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
   /* Process each option */
 
   first = true;
+  lib_memoutstream(&stream, alloca(sizeof(struct utsname)),

Review Comment:
   It is adequate, an extra 7 characters are added when using “uname -a”
   But utsname->sysname is 21 (SYS_NAMELEN) bytes, only 6 bytes ("NuttX") are actually used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org