[GitHub] [skywalking] kezhenxu94 commented on issue #9883: [Feature] Support AWS service monitoring

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1418202569

   > And @hanahmily @kezhenxu94 We don't have Prometheus fetcher anymore, what do you suggest for a new name of `PrometheusMetricConverter`? This class name seems unreasonable in the codes.
   
   It looks reasonable to me because I explain `PrometheusMetricConverter` as "a converter to convert Prometheus metrics format". Besides, we have many other classes/package named with prometheus 👇 all these are referring to the Prometheus data format, not Prometheus fetcher in my mind. 
   
   ```
   import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Counter;
   import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Gauge;
   import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Histogram;
   import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Metric;
   import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Summary;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org