You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/03/06 11:34:29 UTC
[GitHub] [arrow] AlenkaF opened a new pull request, #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
AlenkaF opened a new pull request, #34463:
URL: https://github.com/apache/arrow/pull/34463
### What changes are included in this PR?
List of relevant build options for PyArrow added to the python dev docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127429972
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
Review Comment:
> if you agree it fits.
I'm OK with it.
(Yes, please!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1130583421
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,89 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, debug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 20 20 20
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ - Default value
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ - ``''``
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL=NONE -DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"``)
+ - ``''``
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for Boost (if different from 'boost')
+ - ``''``
Review Comment:
Ah, yes. Sorry, I missed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127400268
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
Review Comment:
Sorry if the questions are silly:
But we can link dynamically to Arrow C++ libs in python I think? And it is also a bit confusing for me that setup.py and CMake that is run from setup.py define different ways to link to the libraries.
Yes, it would be much more clear if this could be aligned or at least I can try to understand and add a sentence or two about this to the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127377240
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
Review Comment:
Thanks for the explanation!
I can remove the variable from setup.py in this PR if you agree it fits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34463:
URL: https://github.com/apache/arrow/pull/34463#issuecomment-1463654254
Benchmark runs are scheduled for baseline = ad44e8e4e669019299dc56b37d24d2976588b648 and contender = 4c05a3b4ea433961e1c546050f4f34356aacded6. 4c05a3b4ea433961e1c546050f4f34356aacded6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2a6288ea754d428387dc579cf7a53748...59e9170d3bf540c08eb295a37663a0c8/)
[Failed :arrow_down:0.97% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/aad9815ce8a24f6fa0e8545887a865c8...776d7185228c4141b64ccaeb3ffa47c5/)
[Finished :arrow_down:1.53% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/19cf1d713e4048249d954958925ff3f9...b8b19cb89714444698a9dea9c0089c6e/)
[Finished :arrow_down:0.85% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4164f8d548c74b93a02196808dbe8c43...5b13222350414f449dc3faa980ee0b13/)
Buildkite builds:
[Finished] [`4c05a3b4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2507)
[Finished] [`4c05a3b4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2537)
[Finished] [`4c05a3b4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2505)
[Finished] [`4c05a3b4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2528)
[Finished] [`ad44e8e4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2506)
[Failed] [`ad44e8e4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2536)
[Finished] [`ad44e8e4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2504)
[Finished] [`ad44e8e4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2527)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34463:
URL: https://github.com/apache/arrow/pull/34463#issuecomment-1459973031
Revision: a4dd385081fbd9ef199b0452715a36cb5172fbd8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7c1c5b5e77](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7c1c5b5e77)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/4363532732/jobs/7629729808)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127470182
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
Review Comment:
Great! Will include the change and test it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1126291178
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
Review Comment:
There is some inconsistency if I am reading the code correctly.
`PYARROW_WITH_STATIC_PARQUET` and `PYARROW_WITH_STATIC_BOOST` are set to `false`/`OFF` (`0`) in setup.py:
https://github.com/apache/arrow/blob/e69a53e9ee8a1c14b9556c1009c12903d89a594b/python/setup.py#L174-L179
but the corresponding flags are set to `ON` in CMakeLists.txt:
https://github.com/apache/arrow/blob/e69a53e9ee8a1c14b9556c1009c12903d89a594b/python/setup.py#L309-L312
https://github.com/apache/arrow/blob/e69a53e9ee8a1c14b9556c1009c12903d89a594b/python/CMakeLists.txt#L119-L123
Will create an issue for it if I am not mistaken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34463:
URL: https://github.com/apache/arrow/pull/34463#issuecomment-1455969306
* Closes: #32619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #34463:
URL: https://github.com/apache/arrow/pull/34463#issuecomment-1459746843
@github-actions crossbow submit wheel-windows*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127378720
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
Review Comment:
Oh yes! Removed it to test and forgot to put it back. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #34463:
URL: https://github.com/apache/arrow/pull/34463#issuecomment-1459967790
@ksuarez1423 pinging you as you might be interested in reviewing the changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #34463:
URL: https://github.com/apache/arrow/pull/34463#issuecomment-1459969349
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1131177614
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,89 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, debug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 20 20 20
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ - Default value
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ - ``''``
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL=NONE -DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"``)
+ - ``''``
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for Boost (if different from 'boost')
+ - ``''``
Review Comment:
Missed it too! Thanks, will remove đź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34463:
URL: https://github.com/apache/arrow/pull/34463#issuecomment-1459751729
Revision: a4dd385081fbd9ef199b0452715a36cb5172fbd8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-481c2526f6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-481c2526f6)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4362567921/jobs/7627616893)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4362569058/jobs/7627619603)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4362567608/jobs/7627616174)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4362568202/jobs/7627617580)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4362569375/jobs/7627620334)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1130570782
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,89 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, debug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 20 20 20
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ - Default value
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ - ``''``
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL=NONE -DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"``)
+ - ``''``
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for Boost (if different from 'boost')
+ - ``''``
+ * - PYARROW_CXXFLAGS
+ - Extra C++ compiler flags
+ - ``''``
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet
+ - ``0`` (``OFF``)
Review Comment:
Here is another Boost reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127429972
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
Review Comment:
> if you agree it fits.
I'm OK with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127009328
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
Review Comment:
```suggestion
- PYARROW_BUILD_TYPE (release, debug or relwithdebinfo)
```
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
Review Comment:
How about removing them because we deprecate Plasma?
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
Review Comment:
Is header missing?
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
+ * - PYARROW_BUNDLE_ARROW_CPP_HEADERS
+ - Bundle the Arrow C++ headers
+ * - PYARROW_BUNDLE_PLASMA_EXECUTABLE
+ - Bundle the plasma-store-server, default ON
Review Comment:
How about remove this?
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
+ * - PYARROW_BUNDLE_ARROW_CPP_HEADERS
+ - Bundle the Arrow C++ headers
+ * - PYARROW_BUNDLE_PLASMA_EXECUTABLE
+ - Bundle the plasma-store-server, default ON
+ * - PYARROW_INSTALL_TESTS
+ - Add the test to the python package, default ON
+ * - PYARROW_BUILD_VERBOSE
+ - Enable verbose output from Makefile builds, default OFF
+ * - PYARROW_PARALLEL
+ - Number of threads used to compile PyArrow’s C++/Cython components
Review Comment:
```suggestion
- Number of processes used to compile PyArrow’s C++/Cython components
```
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
Review Comment:
```suggestion
- Extra C++ compiler flags
```
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
Review Comment:
```suggestion
- Name of install folder for Boost (if different from 'boost')
```
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
Review Comment:
* How about specify option value explicitly in example because users need to specify option value?
* How about specify two options in example to show users can specify multiple options?
```suggestion
- Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL=NONE -DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"``)
```
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
+ * - PYARROW_BUNDLE_ARROW_CPP_HEADERS
+ - Bundle the Arrow C++ headers
Review Comment:
Ah, we can remove this.
It's for `include/arrow/python/`. We always install `include/arrow/python/` (and bundle `include/arrow/`) now because we moved `cpp/src/arrow/python/` to `python/`.
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
Review Comment:
Because `setup.py` uses `STATIC` (not `SHARED`) and `CMakeLists.txt` uses `SHARED` (not `STATIC`).
(We can change `CMakeLists.txt` to use `STATIC` to align names in `setup.py` and `CMakeLists.txt` for easy to understand.)
We can remove `PYARROW_WITH_STATIC_BOOST` because we don't use Boost now.
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
Review Comment:
How about adding one more column for the default value?
Most rows include the default value information in the "Description" column.
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
Review Comment:
I should have removed this in #14925.
This is not used now because Apache Arrow C++'s library part doesn't depend on Boost libraries. (Tests may depend on Boost libraries. Apache Arrow C++'s library part may depend on Boost but it just uses header-only part of Boost.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #34463:
URL: https://github.com/apache/arrow/pull/34463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1130570403
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,89 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, debug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 20 20 20
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ - Default value
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ - ``''``
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL=NONE -DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"``)
+ - ``''``
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for Boost (if different from 'boost')
+ - ``''``
Review Comment:
@kou can this also be removed then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1127447569
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
Review Comment:
> But we can link dynamically to Arrow C++ libs in python I think?
Correct.
> setup.py and CMake that is run from setup.py define different ways to link to the libraries.
Does it mean that `setup.py` says "static or not" and `CMake` says "shared or not"?
Ah, wait. We may be able to remove `PYARROW_WITH_STATIC_PARQUET` too like `PYARROW_WITH_STATIC_BOOST` with the following change:
```diff
diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
index 8f846348f3..2e62dfb0e5 100644
--- a/python/CMakeLists.txt
+++ b/python/CMakeLists.txt
@@ -586,7 +586,7 @@ if(PYARROW_BUILD_PARQUET)
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
endif()
- if(PYARROW_PARQUET_USE_SHARED)
+ if(ARROW_BUILD_SHARED)
if(PYARROW_BUNDLE_ARROW_CPP)
bundle_arrow_lib(${PARQUET_SHARED_LIB} SO_VERSION ${PARQUET_SO_VERSION})
if(MSVC)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1131929466
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,83 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
+ * - ``CMAKE_BUILD_TYPE``
+ - ``PYARROW_BUILD_TYPE`` (release, debug or relwithdebinfo)
Review Comment:
nvm found my answer in setup.py :D
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,83 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
+ * - ``CMAKE_BUILD_TYPE``
+ - ``PYARROW_BUILD_TYPE`` (release, debug or relwithdebinfo)
Review Comment:
Usually the build types are capitalized, is this not the case in pyarrow cmake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1126293694
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
+ * - PYARROW_GENERATE_COVERAGE
+ - Setting ``Xlinetrace`` flag to true for the Cython compiler
+ * - PYARROW_BUNDLE_ARROW_CPP
+ - Bundle the Arrow C++ libraries, default OFF
+ * - PYARROW_BUNDLE_CYTHON_CPP
+ - Bundle the C++ files generated by Cython, default OFF
+ * - PYARROW_BUNDLE_BOOST
+ - Bundle the Boost libraries when we bundle Arrow C++, default OFF
+ * - PYARROW_BUNDLE_ARROW_CPP_HEADERS
+ - Bundle the Arrow C++ headers
Review Comment:
This flag doesn't seem to be used in setup.py or passed to CMake anymore:
https://github.com/apache/arrow/blob/a3cd962b8bc5c49f33824202dff382af13cfa873/python/setup.py#L196-L197
I will also create an issue, if I am not missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org