You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2013/06/07 20:08:17 UTC

Review Request: Fix for test case failure test_network.py:test_delete_account - CLOUDSTACK-2898

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11713/
-----------------------------------------------------------

Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-2898

In this test case we need to capture "cloudstackAPIException" before capturing more generic exceptions


Diffs
-----


Diff: https://reviews.apache.org/r/11713/diff/


Testing
-------

Tested 


Thanks,

Rayees Namathponnan

Re: Review Request: Fix for test case failure test_network.py:test_delete_account - CLOUDSTACK-2898

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11713/#review21796
-----------------------------------------------------------


Commit 19bed631939d7f17ec6e3d1393002b866a458104 in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=19bed63 ]

CLOUDSTACK-2898: Fixing test case issue test_network.py:test_delete_account

When the router for an account is deleted listRouters throws an
exception, handle the exception to pass the test.

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On June 11, 2013, 11:17 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11713/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 11:17 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-2898
> 
> In this test case we need to capture "cloudstackAPIException" before capturing more generic exceptions
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/11713/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Re: Review Request: Fix for test case failure test_network.py:test_delete_account - CLOUDSTACK-2898

Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11713/
-----------------------------------------------------------

(Updated June 11, 2013, 11:17 p.m.)


Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Changes
-------

Attached file 


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-2898

In this test case we need to capture "cloudstackAPIException" before capturing more generic exceptions


Diffs
-----


Diff: https://reviews.apache.org/r/11713/diff/


Testing
-------

Tested 


Thanks,

Rayees Namathponnan

Re: Review Request: Fix for test case failure test_network.py:test_delete_account - CLOUDSTACK-2898

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11713/#review21612
-----------------------------------------------------------


no diff here. did you forget to attach?

- Prasanna Santhanam


On June 7, 2013, 6:08 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11713/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 6:08 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-2898
> 
> In this test case we need to capture "cloudstackAPIException" before capturing more generic exceptions
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/11713/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>