You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by cw...@apache.org on 2019/01/10 19:53:17 UTC

svn commit: r1850975 - /uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java

Author: cwiklik
Date: Thu Jan 10 19:53:17 2019
New Revision: 1850975

URL: http://svn.apache.org/viewvc?rev=1850975&view=rev
Log:
UIMA-5954 Modified to generate DD if a given DD does not exist

Modified:
    uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java

Modified: uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java
URL: http://svn.apache.org/viewvc/uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java?rev=1850975&r1=1850974&r2=1850975&view=diff
==============================================================================
--- uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java (original)
+++ uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java Thu Jan 10 19:53:17 2019
@@ -19,6 +19,7 @@
 package org.apache.uima.ducc.ps.service.main;
 
 
+import java.io.File;
 import java.lang.reflect.Constructor;
 import java.util.Objects;
 import java.util.concurrent.ExecutionException;
@@ -131,7 +132,7 @@ public class ServiceWrapper implements A
 	 * @return
 	 */
 	private boolean isPiecesParts(ServiceConfiguration serviceConfiguration ) {
-		return ( "uima".equals(serviceConfiguration.getJpType()) && serviceConfiguration.getAnalysisEngineDescriptorPath() == null);
+		return ( "uima".equals(serviceConfiguration.getJpType()) );
 	}
 	public void initialize(String[] args ) throws ServiceInitializationException, ServiceException {
 		// collect -Ds and env vars
@@ -146,13 +147,17 @@ public class ServiceWrapper implements A
 		logger.log(Level.INFO, "Deploying service with JMX enabled - clients can connect using jmx URL:"+serviceJmxConnectString);
 		serviceConfiguration.setServiceJmxConnectURL(serviceJmxConnectString);
 		IServiceProcessor processor;
-		if ( isPiecesParts(serviceConfiguration)) {
-			DeployableGeneration dg = new DeployableGeneration(serviceConfiguration);
-			try {
-				analysisEngineDescriptorPath = dg.generate(true);
-				logger.log(Level.INFO, "Deploying UIMA based service using generated (pieces-parts) AE descriptor "+analysisEngineDescriptorPath);
-			} catch( Exception e) {
-				throw new ServiceException("Unable to generate AE descriptor from parts");
+		if ( isPiecesParts(serviceConfiguration) || serviceConfiguration.getAnalysisEngineDescriptorPath() == null ) {
+			if ( !new File(serviceConfiguration.getAnalysisEngineDescriptorPath()).canRead()) {
+				DeployableGeneration dg = new DeployableGeneration(serviceConfiguration);
+				try {
+					analysisEngineDescriptorPath = dg.generate(true);
+					logger.log(Level.INFO, "Deploying UIMA based service using generated (pieces-parts) AE descriptor "+analysisEngineDescriptorPath);
+				} catch( Exception e) {
+					throw new ServiceException("Unable to generate AE descriptor from parts");
+				}
+			} else {
+				analysisEngineDescriptorPath = serviceConfiguration.getAnalysisEngineDescriptorPath();
 			}
 		} else {
 			analysisEngineDescriptorPath = serviceConfiguration.getAnalysisEngineDescriptorPath();