You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by Aaron Radzinski <ar...@datalingvo.com> on 2020/11/19 17:23:54 UTC
[VOTE] Release Apache NLPCraft (incubating) 0.7.2
NLPCraft-ers,
This is a call for a vote to release Apache NLPCraft (incubating) version
0.7.2. This release includes bug fixes, incremental improvements as well as
new management utility.
Release information:
1. Release location:
https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
4. JIRA issues fixed in release:
https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
5. KEYS file:
https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
The vote will be open for at least 72 hours or until a necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thank you,
Aaron (NLPCraft community).
--
Aaron Radzinski
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Nikita Ivanov <ni...@gmail.com>.
+1
- LICENSE, NOTE files exist
- 'mvn clean package verify ' passes & builds on Windows 10 & Ubuntu 20.04
Thanks!
--
Nikita Ivanov
On Thu, Nov 19, 2020 at 9:24 AM Aaron Radzinski <ar...@datalingvo.com>
wrote:
> NLPCraft-ers,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.7.2. This release includes bug fixes, incremental improvements as well as
> new management utility.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Aaron (NLPCraft community).
> --
> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Sergey Kamov <sk...@gmail.com>.
+1
Files checked
CLI - projects generation checked
test (mvn clean verify) checked (macos, java 11)
Regards,
Sergey
21.11.2020 21:55, Aaron Radzinski пишет:
> Sergey,
> Released was patched - please re-download and try again (it was only a test
> fix).
>
> Thank you,
> --
> Aaron Radzinski
>
>
>
> On Fri, Nov 20, 2020 at 4:28 AM Sergey Kamov <sk...@gmail.com> wrote:
>
>> -1
>>
>> gen-project and gen-model prepare invalid yaml and json tempaltes.
>>
>> Should be fixed.
>>
>> I'll create ticket.
>>
>>
>>
>> 19.11.2020 20:23, Aaron Radzinski пишет:
>>> NLPCraft-ers,
>>> This is a call for a vote to release Apache NLPCraft (incubating) version
>>> 0.7.2. This release includes bug fixes, incremental improvements as well
>> as
>>> new management utility.
>>>
>>> Release information:
>>> 1. Release location:
>>>
>> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
>>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
>>> 4. JIRA issues fixed in release:
>>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
>>> 5. KEYS file:
>>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>>>
>>> The vote will be open for at least 72 hours or until a necessary number
>> of
>>> votes are reached.
>>>
>>> Please vote accordingly:
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>>
>>> Thank you,
>>> Aaron (NLPCraft community).
>>> --
>>> Aaron Radzinski
>>>
[RESULT] [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Aaron Radzinski <ar...@datalingvo.com>.
NLPCraft-ers,
The vote for Apache NLPCraft 0.7.2 release is closed now.
Vote result: the vote PASSES with 9 votes +1 and no -1.
+1 votes:
- Aaron Radzinski
- Nikita Ivanov
- Sergey Kamov
- Gleb Ifrops
- Sergey Makov
- Dave Fisher (IPMC)
- Furkan Kamaci (IPMC)
- Konstantin Boudnik (IPMC)
- Paul King (IPMC)
I will proceed with starting the final vote at IPMC shortly.
Thank you,
--
Aaron Radzinski
On Mon, Nov 23, 2020 at 2:10 PM Aaron Radzinski <ar...@datalingvo.com>
wrote:
> Paul,
> https://issues.apache.org/jira/browse/NLPCRAFT-179 filed to be addressed
> in the next release.
>
> Thank you,
> --
> Aaron Radzinski
>
>
>
> On Mon, Nov 23, 2020 at 12:29 AM Paul King <pa...@asert.com.au> wrote:
>
>> +1
>>
>> Checked hashes and signatures.
>> "mvn clean verify" passes
>> "mvn apache-rat:rat" passes
>> incubating in name
>> DISCLAIMER exists
>> NOTICE seems okay
>> LICENSE seems okay
>> no unexpected binary files
>>
>> Mentoring note about license header (same as last time):
>> * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE
>> and
>> NOTICE, thanks) if the statement "Code almost entirely based on work of
>> ..." is indeed true, then I believe it is usually clearer to leave the
>> original license header in the source file and perhaps amend with
>> "Subsequent changes Copyright by the NLPCraft team and made under the
>> ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
>> but my understanding is that you have the obligation to make it clear that
>> the requirements the original author requested for use of that file in
>> source form etc. are still in play and aren't overwritten by slapping the
>> ASLv2 header at the front of the file.
>>
>> Cheers, Paul.
>>
>> On Sun, Nov 22, 2020 at 4:55 AM Aaron Radzinski <
>> aradzinski@datalingvo.com>
>> wrote:
>>
>> > Sergey,
>> > Released was patched - please re-download and try again (it was only a
>> test
>> > fix).
>> >
>> > Thank you,
>> > --
>> > Aaron Radzinski
>> >
>> >
>> >
>> > On Fri, Nov 20, 2020 at 4:28 AM Sergey Kamov <sk...@gmail.com>
>> wrote:
>> >
>> > > -1
>> > >
>> > > gen-project and gen-model prepare invalid yaml and json tempaltes.
>> > >
>> > > Should be fixed.
>> > >
>> > > I'll create ticket.
>> > >
>> > >
>> > >
>> > > 19.11.2020 20:23, Aaron Radzinski пишет:
>> > > > NLPCraft-ers,
>> > > > This is a call for a vote to release Apache NLPCraft (incubating)
>> > version
>> > > > 0.7.2. This release includes bug fixes, incremental improvements as
>> > well
>> > > as
>> > > > new management utility.
>> > > >
>> > > > Release information:
>> > > > 1. Release location:
>> > > >
>> > >
>> >
>> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
>> > > > 3. Git tag:
>> https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
>> > > > 4. JIRA issues fixed in release:
>> > > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
>> > > > 5. KEYS file:
>> > > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>> > > >
>> > > > The vote will be open for at least 72 hours or until a necessary
>> number
>> > > of
>> > > > votes are reached.
>> > > >
>> > > > Please vote accordingly:
>> > > > [ ] +1 approve
>> > > > [ ] +0 no opinion
>> > > > [ ] -1 disapprove with the reason
>> > > >
>> > > > Thank you,
>> > > > Aaron (NLPCraft community).
>> > > > --
>> > > > Aaron Radzinski
>> > > >
>> > >
>> >
>>
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Aaron Radzinski <ar...@datalingvo.com>.
Paul,
https://issues.apache.org/jira/browse/NLPCRAFT-179 filed to be addressed in
the next release.
Thank you,
--
Aaron Radzinski
On Mon, Nov 23, 2020 at 12:29 AM Paul King <pa...@asert.com.au> wrote:
> +1
>
> Checked hashes and signatures.
> "mvn clean verify" passes
> "mvn apache-rat:rat" passes
> incubating in name
> DISCLAIMER exists
> NOTICE seems okay
> LICENSE seems okay
> no unexpected binary files
>
> Mentoring note about license header (same as last time):
> * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE and
> NOTICE, thanks) if the statement "Code almost entirely based on work of
> ..." is indeed true, then I believe it is usually clearer to leave the
> original license header in the source file and perhaps amend with
> "Subsequent changes Copyright by the NLPCraft team and made under the
> ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
> but my understanding is that you have the obligation to make it clear that
> the requirements the original author requested for use of that file in
> source form etc. are still in play and aren't overwritten by slapping the
> ASLv2 header at the front of the file.
>
> Cheers, Paul.
>
> On Sun, Nov 22, 2020 at 4:55 AM Aaron Radzinski <aradzinski@datalingvo.com
> >
> wrote:
>
> > Sergey,
> > Released was patched - please re-download and try again (it was only a
> test
> > fix).
> >
> > Thank you,
> > --
> > Aaron Radzinski
> >
> >
> >
> > On Fri, Nov 20, 2020 at 4:28 AM Sergey Kamov <sk...@gmail.com>
> wrote:
> >
> > > -1
> > >
> > > gen-project and gen-model prepare invalid yaml and json tempaltes.
> > >
> > > Should be fixed.
> > >
> > > I'll create ticket.
> > >
> > >
> > >
> > > 19.11.2020 20:23, Aaron Radzinski пишет:
> > > > NLPCraft-ers,
> > > > This is a call for a vote to release Apache NLPCraft (incubating)
> > version
> > > > 0.7.2. This release includes bug fixes, incremental improvements as
> > well
> > > as
> > > > new management utility.
> > > >
> > > > Release information:
> > > > 1. Release location:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> > > > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> > > > 4. JIRA issues fixed in release:
> > > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> > > > 5. KEYS file:
> > > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > > >
> > > > The vote will be open for at least 72 hours or until a necessary
> number
> > > of
> > > > votes are reached.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > Thank you,
> > > > Aaron (NLPCraft community).
> > > > --
> > > > Aaron Radzinski
> > > >
> > >
> >
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Konstantin Boudnik <co...@apache.org>.
+1 on Paul's license header comment. Missed it, but it is better be
fixed. THanks!
--
With regards,
Cos
On 23.11.2020 03:29, Paul King wrote:
> +1
>
> Checked hashes and signatures.
> "mvn clean verify" passes
> "mvn apache-rat:rat" passes
> incubating in name
> DISCLAIMER exists
> NOTICE seems okay
> LICENSE seems okay
> no unexpected binary files
>
> Mentoring note about license header (same as last time):
> * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE and
> NOTICE, thanks) if the statement "Code almost entirely based on work of
> ..." is indeed true, then I believe it is usually clearer to leave the
> original license header in the source file and perhaps amend with
> "Subsequent changes Copyright by the NLPCraft team and made under the
> ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
> but my understanding is that you have the obligation to make it clear that
> the requirements the original author requested for use of that file in
> source form etc. are still in play and aren't overwritten by slapping the
> ASLv2 header at the front of the file.
>
> Cheers, Paul.
>
> On Sun, Nov 22, 2020 at 4:55 AM Aaron Radzinski <ar...@datalingvo.com>
> wrote:
>
>> Sergey,
>> Released was patched - please re-download and try again (it was only a test
>> fix).
>>
>> Thank you,
>> --
>> Aaron Radzinski
>>
>>
>>
>> On Fri, Nov 20, 2020 at 4:28 AM Sergey Kamov <sk...@gmail.com> wrote:
>>
>>> -1
>>>
>>> gen-project and gen-model prepare invalid yaml and json tempaltes.
>>>
>>> Should be fixed.
>>>
>>> I'll create ticket.
>>>
>>>
>>>
>>> 19.11.2020 20:23, Aaron Radzinski пишет:
>>>> NLPCraft-ers,
>>>> This is a call for a vote to release Apache NLPCraft (incubating)
>> version
>>>> 0.7.2. This release includes bug fixes, incremental improvements as
>> well
>>> as
>>>> new management utility.
>>>>
>>>> Release information:
>>>> 1. Release location:
>>>>
>>>
>> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
>>>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
>>>> 4. JIRA issues fixed in release:
>>>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
>>>> 5. KEYS file:
>>>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>>>>
>>>> The vote will be open for at least 72 hours or until a necessary number
>>> of
>>>> votes are reached.
>>>>
>>>> Please vote accordingly:
>>>> [ ] +1 approve
>>>> [ ] +0 no opinion
>>>> [ ] -1 disapprove with the reason
>>>>
>>>> Thank you,
>>>> Aaron (NLPCraft community).
>>>> --
>>>> Aaron Radzinski
>>>>
>>>
>>
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Paul King <pa...@asert.com.au>.
+1
Checked hashes and signatures.
"mvn clean verify" passes
"mvn apache-rat:rat" passes
incubating in name
DISCLAIMER exists
NOTICE seems okay
LICENSE seems okay
no unexpected binary files
Mentoring note about license header (same as last time):
* For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE and
NOTICE, thanks) if the statement "Code almost entirely based on work of
..." is indeed true, then I believe it is usually clearer to leave the
original license header in the source file and perhaps amend with
"Subsequent changes Copyright by the NLPCraft team and made under the
ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
but my understanding is that you have the obligation to make it clear that
the requirements the original author requested for use of that file in
source form etc. are still in play and aren't overwritten by slapping the
ASLv2 header at the front of the file.
Cheers, Paul.
On Sun, Nov 22, 2020 at 4:55 AM Aaron Radzinski <ar...@datalingvo.com>
wrote:
> Sergey,
> Released was patched - please re-download and try again (it was only a test
> fix).
>
> Thank you,
> --
> Aaron Radzinski
>
>
>
> On Fri, Nov 20, 2020 at 4:28 AM Sergey Kamov <sk...@gmail.com> wrote:
>
> > -1
> >
> > gen-project and gen-model prepare invalid yaml and json tempaltes.
> >
> > Should be fixed.
> >
> > I'll create ticket.
> >
> >
> >
> > 19.11.2020 20:23, Aaron Radzinski пишет:
> > > NLPCraft-ers,
> > > This is a call for a vote to release Apache NLPCraft (incubating)
> version
> > > 0.7.2. This release includes bug fixes, incremental improvements as
> well
> > as
> > > new management utility.
> > >
> > > Release information:
> > > 1. Release location:
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> > > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> > > 4. JIRA issues fixed in release:
> > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> > > 5. KEYS file:
> > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > >
> > > The vote will be open for at least 72 hours or until a necessary number
> > of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thank you,
> > > Aaron (NLPCraft community).
> > > --
> > > Aaron Radzinski
> > >
> >
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Aaron Radzinski <ar...@datalingvo.com>.
Sergey,
Released was patched - please re-download and try again (it was only a test
fix).
Thank you,
--
Aaron Radzinski
On Fri, Nov 20, 2020 at 4:28 AM Sergey Kamov <sk...@gmail.com> wrote:
> -1
>
> gen-project and gen-model prepare invalid yaml and json tempaltes.
>
> Should be fixed.
>
> I'll create ticket.
>
>
>
> 19.11.2020 20:23, Aaron Radzinski пишет:
> > NLPCraft-ers,
> > This is a call for a vote to release Apache NLPCraft (incubating) version
> > 0.7.2. This release includes bug fixes, incremental improvements as well
> as
> > new management utility.
> >
> > Release information:
> > 1. Release location:
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> > 4. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> > 5. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> > Aaron (NLPCraft community).
> > --
> > Aaron Radzinski
> >
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Sergey Kamov <sk...@gmail.com>.
-1
gen-project and gen-model prepare invalid yaml and json tempaltes.
Should be fixed.
I'll create ticket.
19.11.2020 20:23, Aaron Radzinski пишет:
> NLPCraft-ers,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.7.2. This release includes bug fixes, incremental improvements as well as
> new management utility.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Aaron (NLPCraft community).
> --
> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Ifropc <if...@protonmail.com.INVALID>.
+1
Checked the usual:
- mvn clean package verify (Linux)
- signatures
Thanks,
Gleb
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, November 22, 2020 3:21 PM, Konstantin Boudnik <co...@apache.org> wrote:
> +1
>
> all expected files are in place, checksums are fine.
>
> As usual, I can't run tests as the server process can't start in my LXD
> container, but I don't think it reflects on the quality of the release.
>
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> With regards,
> Cos
>
> On 19.11.2020 20:23, Aaron Radzinski wrote:
>
> > NLPCraft-ers,
> > This is a call for a vote to release Apache NLPCraft (incubating) version
> > 0.7.2. This release includes bug fixes, incremental improvements as well as
> > new management utility.
> > Release information:
> >
> > 1. Release location:
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> >
> > 2. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> > 3. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> >
> > 4. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> >
> > The vote will be open for at least 72 hours or until a necessary number of
> > votes are reached.
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> > Aaron (NLPCraft community).
> >
> > ---------------------------------------
> >
> > Aaron Radzinski
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Konstantin Boudnik <co...@apache.org>.
+1
all expected files are in place, checksums are fine.
As usual, I can't run tests as the server process can't start in my LXD
container, but I don't think it reflects on the quality of the release.
--
With regards,
Cos
On 19.11.2020 20:23, Aaron Radzinski wrote:
> NLPCraft-ers,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.7.2. This release includes bug fixes, incremental improvements as well as
> new management utility.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Aaron (NLPCraft community).
> --
> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Sergey Makov <sm...@apache.org>.
+1
- mvn clean package verify (MacOS)
- signatures
Thanks,
Sergey
On Sun, Nov 22, 2020 at 6:03 PM Furkan KAMACI <fu...@gmail.com> wrote:
>
> Hi,
>
> +1 from me.
>
> I checked:
>
> - Incubating in name
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - Checked PGP signatures
> - Checked checksums
> - Code compiles and tests successfully run
> - Apache rat checks are OK
>
> Kind Regards,
> Furkan KAMACI
>
> On Sun, Nov 22, 2020 at 3:40 AM Nikita Ivanov <ni...@gmail.com> wrote:
>
> > +1 (checked again)
> >
> > NOTE: tests were passing for me from maven before: 'mvn clean package
> > verify'.
> >
> > Thanks,
> > --
> > Nikita Ivanov
> >
> >
> >
> > On Sat, Nov 21, 2020 at 2:55 PM Dave Fisher <wa...@apache.org> wrote:
> >
> > > I’ve now checked the new packaging and did a diff on the source trees.
> > >
> > > I’m back to +1 (IPMC binding)
> > >
> > > > On Nov 21, 2020, at 11:32 AM, Dave Fisher <wa...@apache.org> wrote:
> > > >
> > > > Hi -
> > > >
> > > > You really need a new VOTE thread.
> > > >
> > > > My VOTE is no longer valid and is now (-0) until I look again.
> > > >
> > > > Regards,
> > > > Dave
> > > >
> > > >> On Nov 19, 2020, at 10:39 AM, Dave Fisher <wa...@apache.org> wrote:
> > > >>
> > > >> +1 (IPMC binding - carry it over to general for me)
> > > >>
> > > >> Signature, Checksum, Incubating in name, LICENSE, NOTICE, and
> > > DISCLAIMER all good.
> > > >>
> > > >> I understand why there are archives.
> > > >>
> > > >> I don’t have Java 11 installed so it doesn’t build for me.
> > > >>
> > > >> Best Regards,
> > > >> Dave
> > > >>
> > > >>> On Nov 19, 2020, at 9:23 AM, Aaron Radzinski <
> > > aradzinski@datalingvo.com> wrote:
> > > >>>
> > > >>> NLPCraft-ers,
> > > >>> This is a call for a vote to release Apache NLPCraft (incubating)
> > > version
> > > >>> 0.7.2. This release includes bug fixes, incremental improvements as
> > > well as
> > > >>> new management utility.
> > > >>>
> > > >>> Release information:
> > > >>> 1. Release location:
> > > >>>
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> > > >>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> > > >>> 4. JIRA issues fixed in release:
> > > >>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> > > >>> 5. KEYS file:
> > > >>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > > >>>
> > > >>> The vote will be open for at least 72 hours or until a necessary
> > > number of
> > > >>> votes are reached.
> > > >>>
> > > >>> Please vote accordingly:
> > > >>> [ ] +1 approve
> > > >>> [ ] +0 no opinion
> > > >>> [ ] -1 disapprove with the reason
> > > >>>
> > > >>> Thank you,
> > > >>> Aaron (NLPCraft community).
> > > >>> --
> > > >>> Aaron Radzinski
> > > >>
> > > >
> > >
> > >
> >
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked checksums
- Code compiles and tests successfully run
- Apache rat checks are OK
Kind Regards,
Furkan KAMACI
On Sun, Nov 22, 2020 at 3:40 AM Nikita Ivanov <ni...@gmail.com> wrote:
> +1 (checked again)
>
> NOTE: tests were passing for me from maven before: 'mvn clean package
> verify'.
>
> Thanks,
> --
> Nikita Ivanov
>
>
>
> On Sat, Nov 21, 2020 at 2:55 PM Dave Fisher <wa...@apache.org> wrote:
>
> > I’ve now checked the new packaging and did a diff on the source trees.
> >
> > I’m back to +1 (IPMC binding)
> >
> > > On Nov 21, 2020, at 11:32 AM, Dave Fisher <wa...@apache.org> wrote:
> > >
> > > Hi -
> > >
> > > You really need a new VOTE thread.
> > >
> > > My VOTE is no longer valid and is now (-0) until I look again.
> > >
> > > Regards,
> > > Dave
> > >
> > >> On Nov 19, 2020, at 10:39 AM, Dave Fisher <wa...@apache.org> wrote:
> > >>
> > >> +1 (IPMC binding - carry it over to general for me)
> > >>
> > >> Signature, Checksum, Incubating in name, LICENSE, NOTICE, and
> > DISCLAIMER all good.
> > >>
> > >> I understand why there are archives.
> > >>
> > >> I don’t have Java 11 installed so it doesn’t build for me.
> > >>
> > >> Best Regards,
> > >> Dave
> > >>
> > >>> On Nov 19, 2020, at 9:23 AM, Aaron Radzinski <
> > aradzinski@datalingvo.com> wrote:
> > >>>
> > >>> NLPCraft-ers,
> > >>> This is a call for a vote to release Apache NLPCraft (incubating)
> > version
> > >>> 0.7.2. This release includes bug fixes, incremental improvements as
> > well as
> > >>> new management utility.
> > >>>
> > >>> Release information:
> > >>> 1. Release location:
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> > >>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> > >>> 4. JIRA issues fixed in release:
> > >>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> > >>> 5. KEYS file:
> > >>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > >>>
> > >>> The vote will be open for at least 72 hours or until a necessary
> > number of
> > >>> votes are reached.
> > >>>
> > >>> Please vote accordingly:
> > >>> [ ] +1 approve
> > >>> [ ] +0 no opinion
> > >>> [ ] -1 disapprove with the reason
> > >>>
> > >>> Thank you,
> > >>> Aaron (NLPCraft community).
> > >>> --
> > >>> Aaron Radzinski
> > >>
> > >
> >
> >
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Nikita Ivanov <ni...@gmail.com>.
+1 (checked again)
NOTE: tests were passing for me from maven before: 'mvn clean package
verify'.
Thanks,
--
Nikita Ivanov
On Sat, Nov 21, 2020 at 2:55 PM Dave Fisher <wa...@apache.org> wrote:
> I’ve now checked the new packaging and did a diff on the source trees.
>
> I’m back to +1 (IPMC binding)
>
> > On Nov 21, 2020, at 11:32 AM, Dave Fisher <wa...@apache.org> wrote:
> >
> > Hi -
> >
> > You really need a new VOTE thread.
> >
> > My VOTE is no longer valid and is now (-0) until I look again.
> >
> > Regards,
> > Dave
> >
> >> On Nov 19, 2020, at 10:39 AM, Dave Fisher <wa...@apache.org> wrote:
> >>
> >> +1 (IPMC binding - carry it over to general for me)
> >>
> >> Signature, Checksum, Incubating in name, LICENSE, NOTICE, and
> DISCLAIMER all good.
> >>
> >> I understand why there are archives.
> >>
> >> I don’t have Java 11 installed so it doesn’t build for me.
> >>
> >> Best Regards,
> >> Dave
> >>
> >>> On Nov 19, 2020, at 9:23 AM, Aaron Radzinski <
> aradzinski@datalingvo.com> wrote:
> >>>
> >>> NLPCraft-ers,
> >>> This is a call for a vote to release Apache NLPCraft (incubating)
> version
> >>> 0.7.2. This release includes bug fixes, incremental improvements as
> well as
> >>> new management utility.
> >>>
> >>> Release information:
> >>> 1. Release location:
> >>>
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> >>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> >>> 4. JIRA issues fixed in release:
> >>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> >>> 5. KEYS file:
> >>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >>>
> >>> The vote will be open for at least 72 hours or until a necessary
> number of
> >>> votes are reached.
> >>>
> >>> Please vote accordingly:
> >>> [ ] +1 approve
> >>> [ ] +0 no opinion
> >>> [ ] -1 disapprove with the reason
> >>>
> >>> Thank you,
> >>> Aaron (NLPCraft community).
> >>> --
> >>> Aaron Radzinski
> >>
> >
>
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Dave Fisher <wa...@apache.org>.
I’ve now checked the new packaging and did a diff on the source trees.
I’m back to +1 (IPMC binding)
> On Nov 21, 2020, at 11:32 AM, Dave Fisher <wa...@apache.org> wrote:
>
> Hi -
>
> You really need a new VOTE thread.
>
> My VOTE is no longer valid and is now (-0) until I look again.
>
> Regards,
> Dave
>
>> On Nov 19, 2020, at 10:39 AM, Dave Fisher <wa...@apache.org> wrote:
>>
>> +1 (IPMC binding - carry it over to general for me)
>>
>> Signature, Checksum, Incubating in name, LICENSE, NOTICE, and DISCLAIMER all good.
>>
>> I understand why there are archives.
>>
>> I don’t have Java 11 installed so it doesn’t build for me.
>>
>> Best Regards,
>> Dave
>>
>>> On Nov 19, 2020, at 9:23 AM, Aaron Radzinski <ar...@datalingvo.com> wrote:
>>>
>>> NLPCraft-ers,
>>> This is a call for a vote to release Apache NLPCraft (incubating) version
>>> 0.7.2. This release includes bug fixes, incremental improvements as well as
>>> new management utility.
>>>
>>> Release information:
>>> 1. Release location:
>>> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
>>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
>>> 4. JIRA issues fixed in release:
>>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
>>> 5. KEYS file:
>>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>>>
>>> The vote will be open for at least 72 hours or until a necessary number of
>>> votes are reached.
>>>
>>> Please vote accordingly:
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>>
>>> Thank you,
>>> Aaron (NLPCraft community).
>>> --
>>> Aaron Radzinski
>>
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Dave Fisher <wa...@apache.org>.
Hi -
You really need a new VOTE thread.
My VOTE is no longer valid and is now (-0) until I look again.
Regards,
Dave
> On Nov 19, 2020, at 10:39 AM, Dave Fisher <wa...@apache.org> wrote:
>
> +1 (IPMC binding - carry it over to general for me)
>
> Signature, Checksum, Incubating in name, LICENSE, NOTICE, and DISCLAIMER all good.
>
> I understand why there are archives.
>
> I don’t have Java 11 installed so it doesn’t build for me.
>
> Best Regards,
> Dave
>
>> On Nov 19, 2020, at 9:23 AM, Aaron Radzinski <ar...@datalingvo.com> wrote:
>>
>> NLPCraft-ers,
>> This is a call for a vote to release Apache NLPCraft (incubating) version
>> 0.7.2. This release includes bug fixes, incremental improvements as well as
>> new management utility.
>>
>> Release information:
>> 1. Release location:
>> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
>> 4. JIRA issues fixed in release:
>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
>> 5. KEYS file:
>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>>
>> The vote will be open for at least 72 hours or until a necessary number of
>> votes are reached.
>>
>> Please vote accordingly:
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thank you,
>> Aaron (NLPCraft community).
>> --
>> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.2
Posted by Dave Fisher <wa...@apache.org>.
+1 (IPMC binding - carry it over to general for me)
Signature, Checksum, Incubating in name, LICENSE, NOTICE, and DISCLAIMER all good.
I understand why there are archives.
I don’t have Java 11 installed so it doesn’t build for me.
Best Regards,
Dave
> On Nov 19, 2020, at 9:23 AM, Aaron Radzinski <ar...@datalingvo.com> wrote:
>
> NLPCraft-ers,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.7.2. This release includes bug fixes, incremental improvements as well as
> new management utility.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Aaron (NLPCraft community).
> --
> Aaron Radzinski