[GitHub] [incubator-iceberg] danielcweeks commented on a change in pull request #285: Update metadata tables for unpartitioned tables

[GitBox <gi...@apache.org>]

danielcweeks commented on a change in pull request #285: Update metadata tables for unpartitioned tables
URL: https://github.com/apache/incubator-iceberg/pull/285#discussion_r303991846
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
 ##########
 @@ -66,23 +74,26 @@ public String location() {
 
   public static class FilesTableScan extends BaseTableScan {
     private static final long TARGET_SPLIT_SIZE = 32 * 1024 * 1024; // 32 MB
+    private final Schema fileSchema;
 
 Review comment:
   Seems like we're just double capturing a field from BaseTableScan here.  Seem like we should just expose a way to get at the original schema or use the refined schema.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org