You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/19 22:00:40 UTC
[GitHub] [ozone] jwminton opened a new pull request #2436: HDDS-5443 Create and then recreate a bucket with a randomized name
jwminton opened a new pull request #2436:
URL: https://github.com/apache/ozone/pull/2436
## What changes were proposed in this pull request?
Stop using the well known ${BUCKET} value due to side effects of having created a bucket other tests will test for. Uses a randomized bucket name instead that is then confirmed to exist before the second bucket creation command is executed.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5443
## How was this patch tested?
The issue is really only seen when running tests manually and substituting in a custom bucket name, per test instructions and that bucket didn't happen to exist and you were expecting it to still not exist after the test is run.
The changes were tested manually and as part of the s3 acceptance tests since this test is run as part of the s3 acceptance tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2436: HDDS-5443 Create and then recreate a bucket with a randomized name
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2436:
URL: https://github.com/apache/ozone/pull/2436#discussion_r672751362
##########
File path: hadoop-ozone/dist/src/main/smoketest/s3/bucketcreate.robot
##########
@@ -32,7 +32,10 @@ Create new bucket
Create bucket
Create bucket which already exists
- Create bucket with name ${BUCKET}
+ Create bucket with name ${PREFIX}-bucket
+ ${result} = Execute AWSS3APICli list-buckets | jq -r '.Buckets[].Name'
+ Should contain ${result} ${PREFIX}-bucket
+ Create bucket with name ${PREFIX}-bucket
Review comment:
`Create bucket` generates a random name and returns it. Also, `Create bucket with name` verifies that the bucket exists by checking the response for `create-bucket`.
So I think the fix can be simplified a bit:
```suggestion
${bucket} = Create bucket
Create bucket with name ${bucket}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2436: HDDS-5443 Create and then recreate a bucket with a randomized name
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2436:
URL: https://github.com/apache/ozone/pull/2436#discussion_r672751362
##########
File path: hadoop-ozone/dist/src/main/smoketest/s3/bucketcreate.robot
##########
@@ -32,7 +32,10 @@ Create new bucket
Create bucket
Create bucket which already exists
- Create bucket with name ${BUCKET}
+ Create bucket with name ${PREFIX}-bucket
+ ${result} = Execute AWSS3APICli list-buckets | jq -r '.Buckets[].Name'
+ Should contain ${result} ${PREFIX}-bucket
+ Create bucket with name ${PREFIX}-bucket
Review comment:
`Create bucket` generates a random name and returns it. Also, `Create bucket with name` verifies that the bucket exists by checking the response for `create-bucket`.
So I think the fix can be simplified a bit:
```suggestion
${bucket} = Create bucket
Create bucket with name ${bucket}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2436: HDDS-5443 Create and then recreate a bucket with a randomized name
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2436:
URL: https://github.com/apache/ozone/pull/2436#discussion_r672751362
##########
File path: hadoop-ozone/dist/src/main/smoketest/s3/bucketcreate.robot
##########
@@ -32,7 +32,10 @@ Create new bucket
Create bucket
Create bucket which already exists
- Create bucket with name ${BUCKET}
+ Create bucket with name ${PREFIX}-bucket
+ ${result} = Execute AWSS3APICli list-buckets | jq -r '.Buckets[].Name'
+ Should contain ${result} ${PREFIX}-bucket
+ Create bucket with name ${PREFIX}-bucket
Review comment:
`Create bucket` generates a random name and returns it. Also, `Create bucket with name` verifies that the bucket exists by checking the response for `create-bucket`.
So I think the fix can be simplified a bit:
```suggestion
${bucket} = Create bucket
Create bucket with name ${bucket}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2436: HDDS-5443 Create and then recreate a bucket with a randomized name
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2436:
URL: https://github.com/apache/ozone/pull/2436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org