You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Zbigniew Ogledzki (JIRA)" <de...@tapestry.apache.org> on 2008/01/05 07:56:33 UTC
[jira] Commented: (TAPESTRY-1840) tapestry5 still doesnt compile
with java6
[ https://issues.apache.org/jira/browse/TAPESTRY-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556184#action_12556184 ]
Zbigniew Ogledzki commented on TAPESTRY-1840:
---------------------------------------------
Hello, Because I am trying to use it now and found this bug also I prepare a small patch, maybe you will like it :)
It's a basic casting, nothing special.
--
best regards, zgibek
file::java5_to_6.patch:
Index: ../trunk/tapestry-ioc/src/main/java/org/apache/tapestry/ioc/internal/services/ChainBuilderImpl.java
===================================================================
--- ../trunk/tapestry-ioc/src/main/java/org/apache/tapestry/ioc/internal/services/ChainBuilderImpl.java (revision 609060)
+++ ../trunk/tapestry-ioc/src/main/java/org/apache/tapestry/ioc/internal/services/ChainBuilderImpl.java Sat Jan 05 07:48:09 CET 2008
@@ -113,7 +113,7 @@
{
try
{
- Constructor<T> ctor = instanceClass.getConstructors()[0];
+ Constructor<T> ctor = (Constructor<T>) instanceClass.getConstructors()[0];
return instanceClass.cast(ctor.newInstance(commands));
}
> tapestry5 still doesnt compile with java6
> -----------------------------------------
>
> Key: TAPESTRY-1840
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1840
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0
> Reporter: Eirik Maus
> Priority: Trivial
>
> I've tried downloading the sources for tapestry5 and build it just for curiosity's sake. Everytime i try to build it with java6 I get the error below. Haven't any of you tried building it with java6 yet? It's been like that for all releases of java6 i've tried.
> Anyway, it's probably not intended to stay that way. Inserting a cast at the assignment in the reported line will make it compile, but I have no idea if it is correct.
> [INFO] ----------------------------------------------------------------------------
> [INFO] Building Tapestry Inversion of Control Container
> [INFO] task-segment: [install]
> [INFO] ----------------------------------------------------------------------------
> [INFO] [resources:resources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [compiler:compile]
> [INFO] Compiling 172 source files to E:\prosjekter\tapestry5svn\tapestry5\trunk\tapestry-ioc\target\classes
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Compilation failure
> E:\prosjekter\tapestry5svn\tapestry5\trunk\tapestry-ioc\src\main\java\org\apache\tapestry\ioc\internal\services\ChainBuilderImpl.java:[125,65] incompatible types
> found : java.lang.reflect.Constructor<?>
> required: java.lang.reflect.Constructor<T>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org