You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/23 07:28:06 UTC
[GitHub] [dolphinscheduler] SbloodyS opened a new issue #7576: [Feature][Master] Optimize complement task's date
SbloodyS opened a new issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Current complement task's date is left closed and right open time interval (startDate <= N < endDate).From a user's point of view, what you see is what you get.In order that users do not need to transform understanding.I suggest change left closed and right open time interval to left closed and right closed time interval.
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie edited a comment on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1015159242
How about this other daterange fliters in DolphinScheduler? such as "project list"
<img width="1910" alt="image" src="https://user-images.githubusercontent.com/15820530/149895826-2d555733-68e8-4f75-a373-0f2a585da1bd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1011817028
> After parallel complement, the time range of parallel complement is incorrect The selection time is 2022.1.1 ~ 2022.1.3, but only one day of 2022.1.2 data is supplemented  
>
> 
No problem of complement task running. So thie issue will be closed again.
@janeHe13 you can create a new issue of the UI bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1016010561
I think is a little odd here. We have different behavior in our date range filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1015145795
Why we should change strategy to this? IMO, I think we should let users not select the same time in UI, and check is not same datetime in backend. I think using strategy `left closed and right open` is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1015172250
```java
org.apache.dolphinscheduler.service.quartz.cron.CronUtils#getSelfFireDateList(java.util.Date, java.util.Date, java.util.List<org.apache.dolphinscheduler.dao.entity.Schedule>)
```
This method is only used in complement tasks. Then the rest of the daterange filters remains the same.@zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] geosmart commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
geosmart commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1000576616
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1016030754
> I think is a little odd here. We have different behavior in our date range filters.
In order to make it easy for users to understand.I think we should revise other time ranges to be consistent.Just like the same as complement data.
eg:
2022.01.01~2022.01.10
The date range currently selected in the UI:
2022.01.01~2022.01.11
After:
2022.01.01~2022.01.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1016263823
> > I think is a little odd here. We have different behavior in our date range filters.
>
> In order to make it easy for users to understand.I think we should revise other time ranges to be consistent.Just like the same as complement data.
>
> eg: 2022.01.01~2022.01.10
>
> The date range currently selected in the UI: 2022.01.01~2022.01.11
>
> After: 2022.01.01~2022.01.10
Yeah, but indeed, I thinks we should keep date range filter to `left closed and right open`. It make more sence for me. Maybe we should raise an mail thread to discuss it @SbloodyS . **BUT** no matter what conclusion we come to, I think we should keep then same behavior in all our date range filter, to make user in the logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
caishunfeng closed issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1015152908
In order let users do not need to transform understanding. ```left closed and right open``` is a hidden condition. As a user, I often forget this condition when making complement tasks, resulting in missing data.@zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1016273840
> > > I think is a little odd here. We have different behavior in our date range filters.
> >
> >
> > In order to make it easy for users to understand.I think we should revise other time ranges to be consistent.Just like the same as complement data.
> > eg: 2022.01.01~2022.01.10
> > The date range currently selected in the UI: 2022.01.01~2022.01.11
> > After: 2022.01.01~2022.01.10
>
> Yeah, but indeed, I thinks we should keep date range filter to `left closed and right open`. It make more sence for me. Maybe we should raise an mail thread to discuss it @SbloodyS . **BUT** no matter what conclusion we come to, I think we should keep then same behavior in all our date range filter, to make user in the logic
Okay. I'll raise an mail thread to discuss it tonight or tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] janeHe13 commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
janeHe13 commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1011738849
After parallel complement, the time range of parallel complement is incorrect
The selection time is 2022.1.1 ~ 2022.1.3, but only one day of 2022.1.2 data is supplemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1000100761
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
caishunfeng closed issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1015156549
And how about the date range in "timing", it is `left closed and right open` or is `left closed and right closed `?
<img width="1908" alt="image" src="https://user-images.githubusercontent.com/15820530/149895104-27f3c6e4-a2c7-4516-a64b-ee175d748b1b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #7576: [Feature][Master] Optimize complement task's date
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7576:
URL: https://github.com/apache/dolphinscheduler/issues/7576#issuecomment-1015159242
How about this other daterange fliter in DolphinScheduler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org